Skip to content

test: add staging hub server to openapi#71

Merged
xernobyl merged 2 commits into
mainfrom
chore/mpc_server_allowlist
May 7, 2026
Merged

test: add staging hub server to openapi#71
xernobyl merged 2 commits into
mainfrom
chore/mpc_server_allowlist

Conversation

@xernobyl
Copy link
Copy Markdown
Contributor

@xernobyl xernobyl commented May 7, 2026

What does this PR do?

Changes OpenAPI server entries.

This is a focused validation change for ENG-759. Stainless Code Mode is currently receiving the correct FORMBRICKS_HUB_BASE_URL, but its sandbox rejects it. Stainless guidance suggests the sandbox may derive allowed outbound hosts from the OpenAPI servers array used during SDK/MCP generation, so this PR tests that hypothesis by making the staging Hub URL explicit in the uploaded spec.

How should this be tested?

  • go test ./internal/api/handlers ./cmd/api -run 'OpenAPI|HTTPServerServesOpenAPI' -count=1
  • npx --yes @stoplight/spectral-cli@6 lint openapi.yaml
  • After the Stainless preview build completes, run the generated/preview MCP package against staging:
    HUB_API_KEY=<staging-key> \
    FORMBRICKS_HUB_BASE_URL=<hub-urç> \
    npx -y @formbricks/hub-mcp@<preview-version>

@xernobyl xernobyl marked this pull request as ready for review May 7, 2026 10:59
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2026

✱ Stainless preview builds

This PR will update the hub SDKs with the following commit message.

test: add staging hub server to openapi
hub-openapi studio · code

Your SDK build had at least one "note" diagnostic.
generate ✅

hub-typescript studio · code

Your SDK build had at least one "note" diagnostic.
generate ✅build ⏭️lint ⏭️test ✅


This comment is auto-generated by GitHub Actions and is automatically kept up to date as you push.
If you push custom code to the preview branch, re-run this workflow to update the comment.
Last updated: 2026-05-07 15:33:28 UTC

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 7, 2026

Review Change Stack

Walkthrough

This pull request adds a new staging server endpoint to the OpenAPI specification for the Hub. The servers section in openapi.yaml was extended to include the staging Hub instance at https://hub-internal.formbricks.com with a corresponding description. The change is minimal and isolated to the server configuration, with no modifications to API paths, schemas, or components.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding a staging hub server to the OpenAPI spec.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed PR description provides clear context about the change and testing instructions, though some checklist items are not completed.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@xernobyl xernobyl enabled auto-merge May 7, 2026 11:01
@xernobyl xernobyl added this pull request to the merge queue May 7, 2026
Merged via the queue into main with commit bd67631 May 7, 2026
4 of 5 checks passed
@xernobyl xernobyl deleted the chore/mpc_server_allowlist branch May 7, 2026 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants