Skip to content

fix: allow staging hub image tag#72

Merged
BhagyaAmarasinghe merged 1 commit into
mainfrom
fix/staging-hub-worker-image
May 7, 2026
Merged

fix: allow staging hub image tag#72
BhagyaAmarasinghe merged 1 commit into
mainfrom
fix/staging-hub-worker-image

Conversation

@BhagyaAmarasinghe
Copy link
Copy Markdown
Contributor

@BhagyaAmarasinghe BhagyaAmarasinghe commented May 7, 2026

What changed:

  • Adds a manual ECR workflow option to tag a Hub build as staging.
  • Allows staging to be rebuilt from current main with both /app/hub-api and /app/hub-worker in the image.

Tested:

  • git diff --check
  • Dispatched Build & Push to AWS ECR with version_override=0.2.1-staging.20260507 and deploy_staging=true.
  • Restarted hub-stage-worker and verified the rollout succeeded.

Notes:

  • The previous live hub:staging image did not include /app/hub-worker, which caused hub-stage-worker to crash-loop.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 7, 2026

Review Change Stack

Walkthrough

The pull request modifies the build-and-push-ecr workflow to add a new deploy_staging boolean input for workflow_dispatch. This input defaults to false and controls whether an additional :staging tag is appended to the ECR tag list during Docker image building. The input is wired to the "Build ECR tag list" step environment and used in conditional logic that generates the newline-separated TAGS variable, adding the staging tag alongside the existing version and production tag handling.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning PR description lacks structured sections required by template; missing testing instructions, checklist, and formal section headings. Reformat description to follow template: add 'What does this PR do?', 'How should this be tested?', and required/appreciated checklist items.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'fix: allow staging hub image tag' clearly summarizes the main change, which is enabling the ability to tag hub images with a staging tag for ECR deployment.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@xernobyl xernobyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BhagyaAmarasinghe BhagyaAmarasinghe added this pull request to the merge queue May 7, 2026
Merged via the queue into main with commit c201e5e May 7, 2026
4 checks passed
@BhagyaAmarasinghe BhagyaAmarasinghe deleted the fix/staging-hub-worker-image branch May 7, 2026 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants