Skip to content

chore: revert url change; made test broader#74

Closed
xernobyl wants to merge 1 commit into
mainfrom
chore/improve_mcp_test
Closed

chore: revert url change; made test broader#74
xernobyl wants to merge 1 commit into
mainfrom
chore/improve_mcp_test

Conversation

@xernobyl
Copy link
Copy Markdown
Contributor

@xernobyl xernobyl commented May 7, 2026

Summary

Removes the temporary staging Hub URL from the public OpenAPI servers list and keeps the contract generic for self-hosted/local deployments. Also updates the MCP smoke test decoder to support both Stainless hosted Code Mode output and local Code Mode output.

Test Plan

  • npx --yes @stoplight/spectral-cli@6 lint openapi.yaml
  • go test ./internal/api/handlers ./cmd/api -run 'OpenAPI|HTTPServerServesOpenAPI' -count=1
  • Local MCP smoke passed with --code-execution-mode local

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2026

✱ Stainless preview builds

This PR will update the hub SDKs with the following commit message.

chore: revert url change; made test broader

Edit this comment to update it. It will appear in the SDK's changelogs.

hub-openapi studio · code · diff

Your SDK build had at least one "note" diagnostic, but this did not represent a regression.
generate ✅

hub-typescript studio · code · diff

Your SDK build had at least one "note" diagnostic, but this did not represent a regression.
generate ✅build ⏭️lint ⏭️test ✅


This comment is auto-generated by GitHub Actions and is automatically kept up to date as you push.
If you push custom code to the preview branch, re-run this workflow to update the comment.
Last updated: 2026-05-07 17:13:21 UTC

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 7, 2026

Review Change Stack
No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 8495932e-1671-4e61-9838-5c53bd88d980

📥 Commits

Reviewing files that changed from the base of the PR and between bd67631 and e082347.

📒 Files selected for processing (2)
  • openapi.yaml
  • tests/mcp_smoke_test.go
💤 Files with no reviewable changes (1)
  • openapi.yaml

Walkthrough

This PR updates the OpenAPI specification to use templated server URLs with configurable scheme, host, and base path variables, removing an explicit staging server entry. In the MCP smoke test suite, inline JSON decoding logic is extracted into a reusable helper function decodeMCPSmokeResult that handles both wrapped results (under a result key) and direct result shapes, with added unit test validation and integration into the existing test workflow.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main changes: reverting the URL configuration in OpenAPI and broadening the MCP smoke test functionality.
Description check ✅ Passed The description provides a clear summary of changes and a test plan, but lacks the required checklist and detailed 'How should this be tested' section with step-by-step instructions.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@xernobyl xernobyl marked this pull request as draft May 11, 2026 08:40
@xernobyl xernobyl marked this pull request as ready for review May 20, 2026 12:39
@xernobyl xernobyl closed this May 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant