Skip to content

fix(helm): restore TEI float16 dtype#76

Merged
BhagyaAmarasinghe merged 1 commit into
mainfrom
fix/restore-tei-float16-dtype
May 13, 2026
Merged

fix(helm): restore TEI float16 dtype#76
BhagyaAmarasinghe merged 1 commit into
mainfrom
fix/restore-tei-float16-dtype

Conversation

@BhagyaAmarasinghe
Copy link
Copy Markdown
Contributor

Summary

  • restore the default TEI --dtype float16 extra arg for the standalone Hub chart
  • keeps the bundled Alibaba-NLP/gte-multilingual-base CPU deployment within the tested 8Gi memory profile
  • keeps the standalone chart consistent with the Formbricks chart

Verification

  • helm template hub charts/hub --set embeddings.enabled=true --set secrets.existingSecret=hub-secret --show-only templates/embeddings-deployment.yaml
  • helm lint charts/hub --set embeddings.enabled=true --set secrets.existingSecret=hub-secret

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 12, 2026

Review Change Stack
No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 69d59916-2aed-42ca-b8fe-bd61aa4e8cea

📥 Commits

Reviewing files that changed from the base of the PR and between 928c75e and 366d978.

📒 Files selected for processing (1)
  • charts/hub/values.yaml

Walkthrough

This PR adds a new embeddings.extraArgs configuration to the Helm values file for the hub chart. The change supplies --dtype float16 as a command-line argument to the TEI (text-embeddings-inference) embeddings runtime, adjusting the model-serving dtype from its default behavior. The modification is a single configuration addition affecting lines 158–161 in charts/hub/values.yaml.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description covers the main objectives and verification steps but does not include all required template sections like 'How should this be tested?' with step-by-step instructions or the full checklist. Add a structured 'How should this be tested?' section with numbered steps and complete the required checklist items to fully meet the template requirements.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'fix(helm): restore TEI float16 dtype' accurately describes the main change—restoring a TEI dtype configuration in the Helm chart values, which aligns with the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@BhagyaAmarasinghe BhagyaAmarasinghe added this pull request to the merge queue May 13, 2026
Merged via the queue into main with commit 6e7b278 May 13, 2026
3 checks passed
@BhagyaAmarasinghe BhagyaAmarasinghe deleted the fix/restore-tei-float16-dtype branch May 13, 2026 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants