FIO-1217 fix shadowRoot for CalendarWidget#5616
Open
ygist wants to merge 1 commit into
Open
Conversation
To fix an issue where calendar widget's masked date caret position is wrong on shadowDOM CalendarWidget extends Element and uses setInputMask. setInputMask needs shadowRoot for text-mask to work properly. formio#3693 previous fixed the text-mask for other inputs, but the fix does not appear to work for the CalendarWidget because it does not have a (WebForm) root. Relates to https://github.com/text-mask/text-mask/pull/1034/files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To fix an issue where calendar widget's masked date caret position is wrong on shadowDOM
CalendarWidget extends Element and uses setInputMask. setInputMask needs shadowRoot for text-mask to work properly. #3693 previous fixed the text-mask for other inputs, but the fix does not appear to work for the CalendarWidget because it does not have a (WebForm) root.
Relates to https://github.com/text-mask/text-mask/pull/1034/files
https://formio.atlassian.net/browse/FIO-1217