#13 - @reflectable on interface throws NPE in annotation processor

Author: mfriesen

LICENSE_SHORT

@@ -0,0 +1,12 @@
+/**
+ * Copyright [2020] FormKiQ Inc. Licensed under the Apache License, Version 2.0 (the "License"); you
+ * may not use this file except in compliance with the License. You may obtain a copy of the License
+ * at
+ * 
+ * <p>http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * <p>Unless required by applicable law or agreed to in writing, software distributed under the
+ * License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
+ * express or implied. See the License for the specific language governing permissions and
+ * limitations under the License.
+ */

build.gradle

@@ -27,9 +27,10 @@ compileJava {
 }
 
 spotless {
-  java {
-    googleJavaFormat()
-  }
+    java {
+        eclipse().configFile project.rootProject.file("spotless.eclipseformat.xml")
+        licenseHeaderFile project.rootProject.file("LICENSE_SHORT")
+    }
 }
 
 spotbugs {
@@ -45,11 +46,11 @@ spotbugsMain {
 }
 
 checkstyle {
-	toolVersion '8.29'
-	configFile file("config/checkstyle/checkstyle.xml")
-	configProperties = [project_loc: "${projectDir}"]
-	ignoreFailures = false
-  	maxWarnings = 0
+    toolVersion = '10.12.1'
+    configFile file("config/checkstyle/checkstyle.xml")
+    configProperties = [project_loc: "${projectDir}"]
+    maxWarnings = 0
+    maxErrors = 0
 }
 
 repositories {

config/checkstyle/checkstyle.xml

@@ -130,7 +130,7 @@
       <message key="ws.illegalFollow" value="GenericWhitespace ''{0}'' should followed by whitespace."/>
     </module>
     <module name="Indentation">
-      <property name="arrayInitIndent" value="2"/>
+      <property name="arrayInitIndent" value="4"/>
       <property name="basicOffset" value="2"/>
       <property name="caseIndent" value="2"/>
       <property name="lineWrappingIndentation" value="2" />

config/checkstyle/import-control.xml

@@ -16,6 +16,7 @@
 		<allow pkg="java.nio.file" />
 		<allow pkg="java.util" />
 		<allow pkg="java.lang.reflect" />
+		<allow pkg="java.nio.charset" />
 
 		<allow pkg="javax.annotation.processing" />
 		<allow pkg="javax.lang.model" />

spotless.eclipseformat.xml

@@ -153,7 +153,7 @@
 <setting id="org.eclipse.jdt.core.formatter.insert_space_after_colon_in_labeled_statement" value="insert"/>
 <setting id="org.eclipse.jdt.core.formatter.align_type_members_on_columns" value="false"/>
 <setting id="org.eclipse.jdt.core.formatter.alignment_for_assignment" value="16"/>
-<setting id="org.eclipse.jdt.core.formatter.alignment_for_MODULE_statements" value="16"/>
+<setting id="org.eclipse.jdt.core.formatter.alignment_for_module_statements" value="16"/>
 <setting id="org.eclipse.jdt.core.formatter.indent_body_declarations_compare_to_type_header" value="true"/>
 <setting id="org.eclipse.jdt.core.formatter.insert_space_between_empty_parens_in_method_declaration" value="do not insert"/>
 <setting id="org.eclipse.jdt.core.formatter.comment.align_tags_names_descriptions" value="false"/>

src/main/java/com/formkiq/graalvm/processors/GraalvmReflectAnnontationProcessor.java

@@ -2,7 +2,7 @@
  * Copyright [2020] FormKiQ Inc. Licensed under the Apache License, Version 2.0 (the "License"); you
  * may not use this file except in compliance with the License. You may obtain a copy of the License
  * at
- *
+ * 
  * <p>http://www.apache.org/licenses/LICENSE-2.0
  *
  * <p>Unless required by applicable law or agreed to in writing, software distributed under the
@@ -59,13 +59,11 @@
 
 /** Processes {@link Reflectable} {@link ReflectableImport} Annotations. */
 @AutoService(Processor.class)
-@SupportedAnnotationTypes({
-  "com.formkiq.graalvm.annotations.Reflectable",
-  "com.formkiq.graalvm.annotations.ReflectableImport",
-  "com.formkiq.graalvm.annotations.ReflectableClasses",
-  "com.formkiq.graalvm.annotations.ReflectableClass",
-  "com.formkiq.graalvm.annotations.ReflectableClass.ReflectableClasses"
-})
+@SupportedAnnotationTypes({"com.formkiq.graalvm.annotations.Reflectable",
+    "com.formkiq.graalvm.annotations.ReflectableImport",
+    "com.formkiq.graalvm.annotations.ReflectableClasses",
+    "com.formkiq.graalvm.annotations.ReflectableClass",
+    "com.formkiq.graalvm.annotations.ReflectableClass.ReflectableClasses"})
 @SupportedSourceVersion(SourceVersion.RELEASE_11)
 public class GraalvmReflectAnnontationProcessor extends AbstractProcessor {
 
@@ -106,8 +104,8 @@ private List<String> findClasses(final Element element, final String key) {
       Map<? extends ExecutableElement, ? extends AnnotationValue> elementValues =
           annotationMirror.getElementValues();
 
-      for (Map.Entry<? extends ExecutableElement, ? extends AnnotationValue> entry :
-          elementValues.entrySet()) {
+      for (Map.Entry<? extends ExecutableElement, ? extends AnnotationValue> entry : elementValues
+          .entrySet()) {
 
         String simpleNameKey = entry.getKey().getSimpleName().toString();
         Object value = entry.getValue().getValue();
@@ -146,10 +144,8 @@ private Class<?> forName(final String name) throws ClassNotFoundException {
 
       int lastDotIndex = name.lastIndexOf(PACKAGE_SEPARATOR);
       if (lastDotIndex != -1) {
-        String innerClassName =
-            name.substring(0, lastDotIndex)
-                + INNER_CLASS_SEPARATOR
-                + name.substring(lastDotIndex + 1);
+        String innerClassName = name.substring(0, lastDotIndex) + INNER_CLASS_SEPARATOR
+            + name.substring(lastDotIndex + 1);
         return forName(innerClassName);
       }
 
@@ -159,22 +155,16 @@ private Class<?> forName(final String name) throws ClassNotFoundException {
 
   String generateReflectConfigPath(final Set<String> keys) {
 
-    Set<String> strings =
-        keys.stream()
-            .map(this::removePartsContainingDotFollowedByCapital)
-            .filter(m -> m != null && m.length() > 1)
-            .collect(Collectors.toSet());
+    Set<String> strings = keys.stream().map(this::removePartsContainingDotFollowedByCapital)
+        .filter(m -> m != null && m.length() > 1).collect(Collectors.toSet());
 
     if (strings.isEmpty()) {
       strings.add("default");
     }
     final int shortestLength = strings.stream().mapToInt(String::length).min().getAsInt();
 
     List<String> list =
-        strings.stream()
-            .filter(s -> s.length() == shortestLength)
-            .sorted()
-            .toList();
+        strings.stream().filter(s -> s.length() == shortestLength).sorted().toList();
 
     return list.get(0);
   }
@@ -194,9 +184,7 @@ private String getClassNameByType(final Element element) {
       case METHOD:
         className = ((TypeElement) element.getEnclosingElement()).getQualifiedName().toString();
         break;
-      case ENUM:
-      case RECORD:
-      case CLASS:
+      default:
         TypeElement te = (TypeElement) element;
 
         List<String> simpleNames = new ArrayList<>();
@@ -216,9 +204,6 @@ private String getClassNameByType(final Element element) {
             className = e.substring(0, pos) + String.join("$", simpleNames);
           }
         }
-
-        break;
-      default:
         break;
     }
 
@@ -249,8 +234,8 @@ private Reflect getReflect(final String className) {
   }
 
   @Override
-  public boolean process(
-      final Set<? extends TypeElement> annotations, final RoundEnvironment roundEnv) {
+  public boolean process(final Set<? extends TypeElement> annotations,
+      final RoundEnvironment roundEnv) {
 
     if (roundEnv.processingOver()) {
 
@@ -276,8 +261,7 @@ public boolean process(
   private Reflect processClass(final Reflect reflect, final Reflectable reflectable) {
 
     LOGGER.log(LOGLEVEL, "processClass " + reflect.name());
-    reflect
-        .allDeclaredConstructors(reflectable.allDeclaredConstructors())
+    reflect.allDeclaredConstructors(reflectable.allDeclaredConstructors())
         .allDeclaredFields(reflectable.allDeclaredFields())
         .allDeclaredMethods(reflectable.allDeclaredMethods())
         .allPublicConstructors(reflectable.allPublicConstructors())
@@ -297,8 +281,7 @@ private Reflect processClass(final Reflect reflect, final Reflectable reflectabl
   private Reflect processClass(final Reflect reflect, final ReflectableClass reflectable) {
 
     LOGGER.log(LOGLEVEL, "processClass " + reflect.name());
-    reflect
-        .allDeclaredConstructors(reflectable.allDeclaredConstructors())
+    reflect.allDeclaredConstructors(reflectable.allDeclaredConstructors())
         .allDeclaredFields(reflectable.allDeclaredFields())
         .allDeclaredMethods(reflectable.allDeclaredMethods())
         .allPublicConstructors(reflectable.allPublicConstructors())
@@ -334,10 +317,8 @@ private void processImportedClass(final String clazz) {
       for (Method method : forName.getMethods()) {
         Reflectable reflection = method.getAnnotation(Reflectable.class);
         if (reflection != null) {
-          List<String> parameterTypes =
-              Arrays.stream(method.getParameters())
-                  .map(p -> p.getParameterizedType().getTypeName())
-                  .collect(Collectors.toList());
+          List<String> parameterTypes = Arrays.stream(method.getParameters())
+              .map(p -> p.getParameterizedType().getTypeName()).collect(Collectors.toList());
 
           LOGGER.log(LOGLEVEL, "adding Method " + method.getName() + " to " + clazz);
           reflect.addMethod(method.getName(), parameterTypes);
@@ -425,22 +406,15 @@ private void processingReflectable(final RoundEnvironment roundEnv) {
           case METHOD:
             String methodName = element.getSimpleName().toString();
 
-            List<String> parameterTypes =
-                ((ExecutableElement) element)
-                    .getParameters().stream()
-                        .map(param -> param.asType().toString())
-                        .collect(Collectors.toList());
+            List<String> parameterTypes = ((ExecutableElement) element).getParameters().stream()
+                .map(param -> param.asType().toString()).collect(Collectors.toList());
 
             LOGGER.log(LOGLEVEL, "adding Method " + methodName + " to " + className);
             reflect.addMethod(methodName, parameterTypes);
             break;
-          case ENUM:
-          case RECORD:
-          case CLASS:
+          default:
             reflect = processClass(reflect, reflectable);
             break;
-          default:
-            throw new RuntimeException("Unsupported kind of element: " + element.getKind());
         }
       }
     }
@@ -520,9 +494,8 @@ private void processReflectableClasses(final RoundEnvironment roundEnv) {
       }
     }
 
-    Set<? extends Element> reflectableClasses =
-        roundEnv.getElementsAnnotatedWithAny(
-            Set.of(ReflectableClass.class, ReflectableClass.ReflectableClasses.class));
+    Set<? extends Element> reflectableClasses = roundEnv.getElementsAnnotatedWithAny(
+        Set.of(ReflectableClass.class, ReflectableClass.ReflectableClasses.class));
 
     for (Element element : reflectableClasses) {
       String className = getClassNameByType(element);
@@ -536,8 +509,7 @@ private void processReflectableClasses(final RoundEnvironment roundEnv) {
   }
 
   private String removePartsContainingDotFollowedByCapital(final String input) {
-    return Arrays.stream(input.split("\\."))
-        .filter(part -> !part.matches("\\p{Upper}.*"))
+    return Arrays.stream(input.split("\\.")).filter(part -> !part.matches("\\p{Upper}.*"))
         .collect(Collectors.joining("."));
   }
 
@@ -548,13 +520,8 @@ private void writeOutput() {
 
       String name = generateReflectConfigPath(this.reflects.keySet());
 
-      FileObject file =
-          this.processingEnv
-              .getFiler()
-              .createResource(
-                  StandardLocation.CLASS_OUTPUT,
-                  "",
-                  "META-INF/native-image/" + name + "/reflect-config.json");
+      FileObject file = this.processingEnv.getFiler().createResource(StandardLocation.CLASS_OUTPUT,
+          "", "META-INF/native-image/" + name + "/reflect-config.json");
 
       List<Map<String, Object>> data =
           this.reflects.values().stream().map(Reflect::data).collect(Collectors.toList());

src/main/java/com/formkiq/graalvm/processors/Reflect.java

@@ -2,7 +2,7 @@
  * Copyright [2020] FormKiQ Inc. Licensed under the Apache License, Version 2.0 (the "License"); you
  * may not use this file except in compliance with the License. You may obtain a copy of the License
  * at
- *
+ * 
  * <p>http://www.apache.org/licenses/LICENSE-2.0
  *
  * <p>Unless required by applicable law or agreed to in writing, software distributed under the
@@ -34,8 +34,8 @@ public Reflect() {}
    * @param allowUnsafeAccess boolean
    */
   @SuppressWarnings("unchecked")
-  public void addField(
-      final String fieldName, final boolean allowWrite, final boolean allowUnsafeAccess) {
+  public void addField(final String fieldName, final boolean allowWrite,
+      final boolean allowUnsafeAccess) {
 
     if (!this.data.containsKey("methods")) {
       this.data.put("methods", new ArrayList<>());