Skip to content

#24 - Bug: Nested Class return wrong name #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mfriesen merged 1 commit into from
Oct 5, 2025
Merged

#24 - Bug: Nested Class return wrong name #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ plugins {
}

group 'com.formkiq'
version '1.5.0'
version '1.5.1'

dependencies {
annotationProcessor group: 'com.google.auto.service', name: 'auto-service', version: '1.1.1'
Expand Down
8 changes: 7 additions & 1 deletion src/main/java/com/formkiq/graalvm/processors/GraalvmReflectAnnontationProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@
import javax.lang.model.element.TypeElement;
import javax.lang.model.type.MirroredTypeException;
import javax.lang.model.type.TypeMirror;
import javax.lang.model.util.Elements;
import javax.lang.model.util.Types;
import javax.tools.FileObject;
import javax.tools.StandardLocation;
Expand Down Expand Up @@ -194,7 +195,7 @@ private String getClassNameByType(final Element element) {
result = result.getEnclosingElement();
}

className = te.getQualifiedName().toString();
className = getBinaryName(te);

if (!simpleNames.isEmpty()) {
String e = element.getEnclosingElement().toString();
Expand All @@ -210,6 +211,11 @@ private String getClassNameByType(final Element element) {
return className;
}

public String getBinaryName(final TypeElement typeElement) {
Elements elements = processingEnv.getElementUtils();
return elements.getBinaryName(typeElement).toString();
}

/**
* Get {@link Reflect}.
*
Expand Down
42 changes: 42 additions & 0 deletions src/test/java/com/formkiq/graalvm/processors/GraalvmReflectAnnontationProcessorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -835,6 +835,48 @@ public record TestRecord(String name) {}
assertEquals(Boolean.TRUE, map.get(0).get("allDeclaredFields"));
}

/**
* test nested java record.
*
* @throws IOException IOException
*/
@Test
public void testNestedRecordAnnotations() throws IOException {
JavaFileObject recordSource = JavaFileObjects.forSourceString("com.example.TestRecord", """
package com.example;

import com.formkiq.graalvm.annotations.Reflectable;

@Reflectable
public record TestRecord(String name) {
@Reflectable
public record NestedTestRecord(String name) {
}
}
""");
Compilation compilation =
javac().withProcessors(new GraalvmReflectAnnontationProcessor()).compile(recordSource);

List<Map<String, Object>> map = getReflectConf(compilation, "com.example");

assertEquals(2, map.size());
assertEquals("com.example.TestRecord", map.get(0).get("name"));
assertEquals(Boolean.TRUE, map.get(0).get("allPublicConstructors"));
assertEquals(Boolean.TRUE, map.get(0).get("allPublicMethods"));
assertEquals(Boolean.TRUE, map.get(0).get("allPublicFields"));
assertEquals(Boolean.FALSE, map.get(0).get("allDeclaredConstructors"));
assertEquals(Boolean.TRUE, map.get(0).get("allDeclaredMethods"));
assertEquals(Boolean.TRUE, map.get(0).get("allDeclaredFields"));

assertEquals("com.example.TestRecord$NestedTestRecord", map.get(1).get("name"));
assertEquals(Boolean.TRUE, map.get(0).get("allPublicConstructors"));
assertEquals(Boolean.TRUE, map.get(0).get("allPublicMethods"));
assertEquals(Boolean.TRUE, map.get(0).get("allPublicFields"));
assertEquals(Boolean.FALSE, map.get(0).get("allDeclaredConstructors"));
assertEquals(Boolean.TRUE, map.get(0).get("allDeclaredMethods"));
assertEquals(Boolean.TRUE, map.get(0).get("allDeclaredFields"));
}

/**
* test java record.
*
Expand Down