PHP 8 updates - installation script fixes

Author: benkeen

.nvmrc

@@ -0,0 +1 @@
+v16.19.1

DEVELOPMENT.md

@@ -13,9 +13,9 @@ up in your browser, but now we've finally added a proper build process.
 ### Local development
 
 With 3.0.14 Form Tools source code was moved to a `src/` folder in the repo and all build artifacts are generated
-into a `dist/` folder. 
+into a `dist/` folder.
 
-After checking out the repo run these commands. 
+After checking out the repo run these commands.
 
 ```
 yarn install
@@ -92,4 +92,4 @@ and create a tag with the name specified.
 Please note:
 - the main `global/Core.class.php` should have been updated with the correct version.
 
-At that point we can just generate the new release from the `releases` branch via github as before. 
+At that point we can just generate the new release from the `releases` branch via github as before. 

gruntfile.js

@@ -1,7 +1,7 @@
 const fs = require('fs');
 const path = require('path');
 const lineByLine = require('n-readlines');
-const sass = require('node-sass');
+const sass = require('sass');
 const pkg = require('./package.json');
 const child_process = require('child_process');
 

package.json

@@ -112,11 +112,11 @@
     "mini-css-extract-plugin": "^0.8.0",
     "moment": "^2.22.2",
     "n-readlines": "^1.0.0",
-    "node-sass": "^4.12.0",
     "postcss-loader": "^3.0.0",
     "prop-types": "^15.6.1",
     "reselect": "^3.0.1",
     "resolve-url-loader": "^3.1.0",
+    "sass": "1.58.3",
     "sass-loader": "^7.2.0",
     "sinon": "^7.5.0",
     "style-loader": "^1.0.0",

src/global/code/Emails.class.php

@@ -301,7 +301,7 @@ public static function sendTestEmail($info)
 		$email_id = Sessions::get("email_id");
 		$submission_id = (isset($info["submission_id"]) && !empty($info["submission_id"])) ? $info["submission_id"] : "";
 
-		list ($success, $email_info) = self::getEmailComponents($form_id, $submission_id, $email_id, true, $info);
+		list ($success, $email_info) = self::getEmailComponents($form_id, $email_id, $submission_id, true, $info);
 		if (!$success) {
 			return array(false, $email_info);
 		}
@@ -386,7 +386,7 @@ public static function sendTestEmail($info)
 	 * @param integer $email_id
 	 * @return array
 	 */
-	public static function getEmailComponents($form_id, $submission_id = "", $email_id, $is_test = false, $test_settings = array())
+	public static function getEmailComponents($form_id, $email_id, $submission_id = "", $is_test = false, $test_settings = array())
 	{
 		$LANG = Core::$L;
 		$root_dir = Core::getRootDir();
@@ -1282,7 +1282,7 @@ public static function sendEmails($event, $form_id, $submission_id)
 	 */
 	public static function processEmailTemplate($form_id, $submission_id, $email_id)
 	{
-		list($success, $email_components) = self::getEmailComponents($form_id, $submission_id, $email_id);
+		list($success, $email_components) = self::getEmailComponents($form_id, $email_id, $submission_id);
 
 		if (!$success) {
 			return array(false, "Email components not returned properly (Emails::getEmailComponents).");

src/global/code/FieldTypes.class.php

@@ -710,7 +710,7 @@ public static function getFieldTypeProcessingInfo()
 	 * @param $field_ids
 	 * @return array a hash of [field_id][identifier] = values
 	 */
-	public static function getFormFieldFieldTypeSettings($field_ids = array(), $form_fields)
+	public static function getFormFieldFieldTypeSettings($field_ids = array(), $form_fields = array())
 	{
 		$db = Core::$db;
 
@@ -1439,7 +1439,7 @@ public static function get($return_settings = false, $field_type_ids = array())
                 SELECT *, g.list_order as group_list_order, ft.list_order as field_type_list_order
                 FROM   {PREFIX}field_types ft, {PREFIX}list_groups g
                 WHERE  g.group_type = :field_types AND
-                       ft.group_id = g.group_id AND 
+                       ft.group_id = g.group_id AND
                        ft.field_type_id IN ($field_type_id_str)
                 ORDER BY g.list_order, ft.list_order
             ");
@@ -1534,7 +1534,7 @@ public static function addFieldTypeSettingOptions($options)
 	{
 		$db = Core::$db;
 
-		$query = "INSERT INTO {PREFIX}field_type_setting_options (setting_id, option_text, option_value, option_order, 
+		$query = "INSERT INTO {PREFIX}field_type_setting_options (setting_id, option_text, option_value, option_order,
             is_new_sort_group) VALUES (:setting_id, :option_text, :option_value, :option_order, :is_new_sort_group)";
 
 		foreach ($options as $option) {
@@ -1558,7 +1558,7 @@ public static function deleteFieldTypeSettingsByFieldTypeId($field_type_id)
 		$db->query("
             SELECT setting_id
             FROM   {PREFIX}field_type_settings
-            WHERE  field_type_id = :field_type_id 
+            WHERE  field_type_id = :field_type_id
         ");
 		$db->bind("field_type_id", $field_type_id);
 		$db->execute();
@@ -1878,7 +1878,7 @@ public static function resetFieldTypeSettings ($field_type_data)
 			// here, this is a new setting added to the field type that the users installation doesn't have
 			if ($found_setting === null) {
 				$db->query("
-					INSERT INTO {PREFIX}field_type_settings (field_label, field_type, field_orientation, default_value_type, 
+					INSERT INTO {PREFIX}field_type_settings (field_label, field_type, field_orientation, default_value_type,
 						default_value, list_order)
 					VALUES (:field_label, :field_type, :field_orientation, :default_value_type, :default_value, :list_order)
 				");

src/global/code/actions.php

@@ -171,7 +171,7 @@
 	case "display_test_email":
 		$form_id  = Sessions::get("form_id");
 		$email_id = Sessions::get("email_id");
-		$info = Emails::getEmailComponents($form_id, "", $email_id, true, $request);
+		$info = Emails::getEmailComponents($form_id, $email_id, "", true, $request);
 		echo returnJSON($info);
 		break;