react/redux admin dashboard#2
Open
forsaken1 wants to merge 36 commits into
Open
Conversation
|
React.js code review notes:
|
gEndelf
reviewed
Jun 27, 2019
| @@ -0,0 +1,30 @@ | |||
| import React, { Component } from "react"; | |||
|
|
|||
| class City extends Component { | |||
There was a problem hiding this comment.
- make component refactoring (City/Team/User). Look like - it can be single component EditableLabel
- add PropTypes
- don't use data structures - which will be not used (data...). Component has to accept only required data, nothing more
| }; | ||
| } | ||
|
|
||
| componentDidMount() { |
There was a problem hiding this comment.
- add error handler
- extract logic into function or into app state (see redux)
|
|
||
| import "../styles/Result.css" | ||
|
|
||
| class Result extends Component { |
There was a problem hiding this comment.
- user props, don't use state in container component, just props (you don't need to edit anything here)
- move component into .../containers/Results.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.