Fix mutation of cache objects causing base64 responses#173
Merged
AyronK merged 1 commit intofortedigital:masterfrom Dec 8, 2025
Merged
Fix mutation of cache objects causing base64 responses#173AyronK merged 1 commit intofortedigital:masterfrom
base64 responses#173AyronK merged 1 commit intofortedigital:masterfrom
Conversation
Redis handler mutated the original `cacheHandlerValue` object Next.js uses for responses. When `parseBuffersToStrings()` converted Buffers to base64, Next.js sent the mutated object to users. So we clone value object before mutation to isolate changes from Next.js's reference.
ec7f298 to
a3599bb
Compare
Contributor
Author
|
@AyronK this is also a bug in Next.js 15.x. Can we get this released please? |
Collaborator
|
@m-sanders I will take a look today, thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redis handler mutated the original
cacheHandlerValueobject Next.js uses for responses. WhenparseBuffersToStrings()converted Buffers to base64, Next.js sent the mutated object to users. We shallow clone value object before mutation to isolate changes from Next.js's reference.How was this tested?
Manually