Skip to content

fix(cache-handler): persist implicit path tags for PAGES entries #227

Open
KajSzy wants to merge 3 commits into
fortedigital:masterfrom
KajSzy:feat/redis-e2e-integration-tests
Open

fix(cache-handler): persist implicit path tags for PAGES entries #227
KajSzy wants to merge 3 commits into
fortedigital:masterfrom
KajSzy:feat/redis-e2e-integration-tests

Conversation

@KajSzy

@KajSzy KajSzy commented May 25, 2026

Copy link
Copy Markdown
Contributor

When working with nextjs project using nextjs-cache-handler I've came up with a workflow how to validate implementation and integration with nextjs itself.

This PR introduces integration tests github workflow and fix for revalidatePath not working with pages router which is rare situation but still should be supported (ie big projects migrating from pages to app router)

KajSzy added 3 commits May 25, 2026 15:31
revalidatePath invalidates via _N_T_ path tags in Redis; Pages Router
HTML cache entries did not store them on set or registerInitialCache.
Add CI workflow, example page test hooks, and specs covering cache hits,
revalidatePath, revalidateTag, and tag profiles against a live Redis stack.
Drop Redis service health options, debug cache env, and turbo test:e2e env passthrough. Rename cache-behavior spec to path-revalidation with App/Pages Router describe blocks.
@AyronK

AyronK commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

For some reason I lost notifications about PRs/Issues in this repo. Sorry for that. I'll review the PR this week 🫡.

@AyronK AyronK self-requested a review June 17, 2026 09:39

@AyronK AyronK left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall great addition @KajSzy, thanks for the e2e setup, that's huge. I noticed some tests are a bit flaky, at least locally:
image
image

Could you verify and fix/remove flaky tests that would only add extra work to maintenance?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants