Enhancement: Add csc2dense conversion routine to complete dense API#1158
Merged
Conversation
Contributor
Author
jalvesz
requested changes
Mar 26, 2026
Contributor
jalvesz
left a comment
jalvesz
left a comment
There was a problem hiding this comment.
Thanks for taking a look at this, please add the tests and documentation.
srinjoy933
force-pushed
the
feat-csc2dense2
branch
from
782a15b to
937f276
Compare
Contributor
Author
|
hey @jalvesz I made the changes according to what you have suggested. Please have a look at this pr .Thank you for your suggestions. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1158 +/- ##
==========================================
+ Coverage 68.00% 68.04% +0.03%
==========================================
Files 404 404
Lines 12935 12948 +13
Branches 1392 1395 +3
==========================================
+ Hits 8797 8810 +13
Misses 4138 4138 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jalvesz
requested changes
Mar 29, 2026
jalvesz
approved these changes
Mar 30, 2026
jvdp1
approved these changes
Apr 1, 2026
Member
jvdp1
left a comment
jvdp1
left a comment
There was a problem hiding this comment.
thank you @srinjoy933 for this PR and the addition of csc2dense.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SOLVE #1156