fix(datetime): correct divisor in civil_from_days (1461 → 1460)#1190
Open
cyrilgandon wants to merge 1 commit into
Open
fix(datetime): correct divisor in civil_from_days (1461 → 1460)#1190cyrilgandon wants to merge 1 commit into
cyrilgandon wants to merge 1 commit into
Conversation
cyrilgandon
force-pushed
the
fix/civil_from_days_leap_years
branch
2 times, most recently
from
1c45787 to
0408d10
Compare
jalvesz
approved these changes
Jun 23, 2026
jalvesz
left a comment
jalvesz
left a comment
Contributor
There was a problem hiding this comment.
LGTM @cyrilgandon thanks for finding and fixing this.
Author
|
There seems to be an issue with the code coverage report. I'm not sure what the right fix is, so I'll leave it to the maintainer to handle. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing #1189
I noticed that the yoe (year of era) computation in src/stdlib_datetime.f90 differs from Howard Hinnant's reference algorithm (date_algorithms).
Reference:
const unsigned yoe = (doe - doe/1460 + doe/36524 - doe/146096) / 365; // [0, 399]Current code in stdlib_datetime.f90:
yoe = (doe - doe/1461 + doe/36524 - doe/146096) / 365The divisor differs: 1460 in the reference versus 1461 here.