fix(e2e): probe tauri-webdriver readiness + binary-path fallback + fail CI on test

  failure

  - setup/global.ts now polls /status, detects driver crash during startup,
    and writes stdout/stderr to reports/ so failures land in the existing
    artifact upload instead of being lost in xvfb-run output.
  - support/platform.ts probes both target/<triple>/debug and target/debug
    so macOS rows where --target matches the host triple stop failing with
    "binary not found".
  - e2e-webview.yml gets a post-test gate that re-asserts failure based on
    the continue-on-error test step outcomes — without it the job was green
    even when every spec failed.

Author: shaunwarman

.github/workflows/e2e-webview.yml

@@ -241,3 +241,13 @@ jobs:
           path: e2e-webview/screenshots/
           if-no-files-found: ignore
           retention-days: 7
+
+      - name: Fail job if tests failed
+        # The test steps use continue-on-error so the artifact-upload steps
+        # above always run on failure. This gate restores red CI when any
+        # spec fails — without it, a failing matrix row reports green.
+        if: ${{ steps.gate.outputs.skip != 'true' && (steps.test-linux.outcome == 'failure' || steps.test-other.outcome == 'failure') }}
+        shell: bash
+        run: |
+          echo "::error::E2E tests failed on ${{ matrix.label }} — see job logs and uploaded artifacts."
+          exit 1

e2e-webview/setup/global.ts

@@ -1,18 +1,85 @@
 import { spawn, type ChildProcess } from 'node:child_process';
+import { setTimeout as delay } from 'node:timers/promises';
+import fs from 'node:fs';
+import path from 'node:path';
+
+const HOST = '127.0.0.1';
+const PORT = 4444;
+const READY_TIMEOUT_MS = 30_000;
+const POLL_INTERVAL_MS = 250;
+const STATUS_URL = `http://${HOST}:${PORT}/status`;
+
+const REPORTS_DIR = path.resolve('./reports');
+fs.mkdirSync(REPORTS_DIR, { recursive: true });
 
 export default async function globalSetup() {
+  const stdoutPath = path.join(REPORTS_DIR, 'tauri-webdriver.stdout.log');
+  const stderrPath = path.join(REPORTS_DIR, 'tauri-webdriver.stderr.log');
+  const stdoutLog = fs.createWriteStream(stdoutPath);
+  const stderrLog = fs.createWriteStream(stderrPath);
+
   const driver: ChildProcess = spawn('tauri-webdriver', [], {
-    stdio: 'inherit',
+    stdio: ['ignore', 'pipe', 'pipe'],
     shell: process.platform === 'win32',
   });
 
-  await new Promise<void>((resolve, reject) => {
-    driver.once('error', reject);
-    // tauri-webdriver binds ports synchronously on startup; 2s is plenty.
-    setTimeout(resolve, 2_000);
+  driver.stdout?.on('data', (chunk: Buffer) => {
+    stdoutLog.write(chunk);
+    process.stdout.write(chunk);
+  });
+  driver.stderr?.on('data', (chunk: Buffer) => {
+    stderrLog.write(chunk);
+    process.stderr.write(chunk);
+  });
+
+  type ExitInfo = { code: number | null; signal: NodeJS.Signals | null };
+  const exitState: { value: ExitInfo | null } = { value: null };
+  driver.once('exit', (code, signal) => {
+    exitState.value = { code, signal };
+  });
+
+  const spawnFailed = new Promise<never>((_, reject) => {
+    driver.once('error', (err) =>
+      reject(new Error(`tauri-webdriver failed to spawn: ${(err as Error).message}`)),
+    );
   });
 
+  const ready = (async () => {
+    const deadline = Date.now() + READY_TIMEOUT_MS;
+    while (Date.now() < deadline) {
+      const exited = exitState.value;
+      if (exited) {
+        throw new Error(
+          `tauri-webdriver exited during startup (code=${exited.code}, signal=${exited.signal}). ` +
+            `See ${path.relative(process.cwd(), stderrPath)} for driver output.`,
+        );
+      }
+      try {
+        const res = await fetch(STATUS_URL, { signal: AbortSignal.timeout(1_000) });
+        if (res.ok) return;
+      } catch {
+        // not yet — keep polling
+      }
+      await delay(POLL_INTERVAL_MS);
+    }
+    throw new Error(
+      `tauri-webdriver did not become ready on ${STATUS_URL} within ${READY_TIMEOUT_MS}ms. ` +
+        `See ${path.relative(process.cwd(), stderrPath)} for driver output.`,
+    );
+  })();
+
+  try {
+    await Promise.race([ready, spawnFailed]);
+  } catch (err) {
+    if (driver.exitCode === null && !driver.killed) driver.kill('SIGTERM');
+    stdoutLog.end();
+    stderrLog.end();
+    throw err;
+  }
+
   return async () => {
-    if (!driver.killed) driver.kill('SIGTERM');
+    if (driver.exitCode === null && !driver.killed) driver.kill('SIGTERM');
+    stdoutLog.end();
+    stderrLog.end();
   };
 }

e2e-webview/support/platform.ts

@@ -10,28 +10,30 @@ export function resolveAppBinary(): string {
 
   const target = process.env.TAURI_TARGET;
   const repoRoot = path.resolve(process.cwd(), '..');
-  const targetDir = path.join(
-    repoRoot,
-    'src-tauri',
-    'target',
-    ...(target ? [target] : []),
-    'debug',
-  );
-
   const binaryName = process.platform === 'win32' ? `${CRATE}.exe` : CRATE;
-  const binaryPath = path.join(targetDir, binaryName);
 
-  if (!fs.existsSync(binaryPath)) {
-    throw new Error(
-      [
-        `Tauri debug binary not found at ${binaryPath}.`,
-        `Build it first from the repo root:`,
-        `  pnpm tauri build --debug --no-bundle --features webdriver${target ? ` --target ${target}` : ''}`,
-        `(plain "cargo build" produces a binary with no embedded frontendDist —`,
-        ` use the tauri CLI so index.html is registered.)`,
-        `Or set TAURI_E2E_BINARY to an explicit path.`,
-      ].join('\n'),
-    );
+  // Cargo writes to target/<triple>/debug when --target is passed and the
+  // triple differs from the host. On some CI configurations (notably the
+  // macos-15-intel runner with --target x86_64-apple-darwin matching the
+  // host triple) the output lands at target/debug instead. Probe both.
+  const candidates = [
+    ...(target ? [path.join(repoRoot, 'src-tauri', 'target', target, 'debug', binaryName)] : []),
+    path.join(repoRoot, 'src-tauri', 'target', 'debug', binaryName),
+  ];
+
+  for (const candidate of candidates) {
+    if (fs.existsSync(candidate)) return candidate;
   }
-  return binaryPath;
+
+  throw new Error(
+    [
+      `Tauri debug binary not found. Searched:`,
+      ...candidates.map((c) => `  - ${c}`),
+      `Build it first from the repo root:`,
+      `  pnpm tauri build --debug --no-bundle --features webdriver${target ? ` --target ${target}` : ''}`,
+      `(plain "cargo build" produces a binary with no embedded frontendDist —`,
+      ` use the tauri CLI so index.html is registered.)`,
+      `Or set TAURI_E2E_BINARY to an explicit path.`,
+    ].join('\n'),
+  );
 }