Skip to content

Commit 1d12e9e

Browse files
committed
use error log instead of debug
1 parent 08cca8d commit 1d12e9e

1 file changed

Lines changed: 10 additions & 10 deletions

File tree

updater/msirunner.go

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -52,15 +52,15 @@ func runMsi(msi *tempFile, userToken uintptr) error {
5252
logger.Debug("Updater: Getting system directory")
5353
system32, err := windows.GetSystemDirectory()
5454
if err != nil {
55-
logger.Debug("Updater: Failed to get system directory: %v", err)
55+
logger.Error("Updater: Failed to get system directory: %v", err)
5656
return err
5757
}
5858
logger.Debug("Updater: System directory: %s", system32)
5959

6060
logger.Debug("Updater: Opening /dev/null for process I/O")
6161
devNull, err := os.OpenFile(os.DevNull, os.O_RDWR, 0)
6262
if err != nil {
63-
logger.Debug("Updater: Failed to open /dev/null: %v", err)
63+
logger.Error("Updater: Failed to open /dev/null: %v", err)
6464
return err
6565
}
6666
defer devNull.Close()
@@ -83,21 +83,21 @@ func runMsi(msi *tempFile, userToken uintptr) error {
8383

8484
proc, err := os.StartProcess(msiexec, []string{msiexec, "/qb!-", "/i", filepath.Base(msiPath)}, attr)
8585
if err != nil {
86-
logger.Debug("Updater: Failed to start msiexec process: %v", err)
86+
logger.Error("Updater: Failed to start msiexec process: %v", err)
8787
return fmt.Errorf("failed to start msiexec: %w", err)
8888
}
8989
logger.Debug("Updater: msiexec process started (PID: %d)", proc.Pid)
9090

9191
logger.Debug("Updater: Waiting for msiexec to complete")
9292
state, err := proc.Wait()
9393
if err != nil {
94-
logger.Debug("Updater: Error waiting for msiexec: %v", err)
94+
logger.Error("Updater: Error waiting for msiexec: %v", err)
9595
return err
9696
}
9797
logger.Debug("Updater: msiexec completed with exit code: %d", state.ExitCode())
9898

9999
if !state.Success() {
100-
logger.Debug("Updater: msiexec failed with exit code: %d", state.ExitCode())
100+
logger.Error("Updater: msiexec failed with exit code: %d", state.ExitCode())
101101
return &exec.ExitError{ProcessState: state}
102102
}
103103
logger.Debug("Updater: MSI installation completed successfully")
@@ -109,19 +109,19 @@ func msiTempFile() (*tempFile, error) {
109109
var randBytes [32]byte
110110
n, err := rand.Read(randBytes[:])
111111
if err != nil {
112-
logger.Debug("Updater: Failed to generate random bytes: %v", err)
112+
logger.Error("Updater: Failed to generate random bytes: %v", err)
113113
return nil, err
114114
}
115115
if n != int(len(randBytes)) {
116-
logger.Debug("Updater: Insufficient random bytes generated: %d", n)
116+
logger.Error("Updater: Insufficient random bytes generated: %d", n)
117117
return nil, errors.New("Unable to generate random bytes")
118118
}
119119
logger.Debug("Updater: Generated random filename")
120120

121121
logger.Debug("Updater: Creating security descriptor")
122122
sd, err := windows.SecurityDescriptorFromString("O:SYD:PAI(A;;FA;;;SY)(A;;FR;;;BA)")
123123
if err != nil {
124-
logger.Debug("Updater: Failed to create security descriptor: %v", err)
124+
logger.Error("Updater: Failed to create security descriptor: %v", err)
125125
return nil, err
126126
}
127127
sa := &windows.SecurityAttributes{
@@ -132,7 +132,7 @@ func msiTempFile() (*tempFile, error) {
132132
logger.Debug("Updater: Getting Windows directory")
133133
windir, err := windows.GetWindowsDirectory()
134134
if err != nil {
135-
logger.Debug("Updater: Failed to get Windows directory: %v", err)
135+
logger.Error("Updater: Failed to get Windows directory: %v", err)
136136
return nil, err
137137
}
138138
name := filepath.Join(windir, "Temp", hex.EncodeToString(randBytes[:]))
@@ -143,7 +143,7 @@ func msiTempFile() (*tempFile, error) {
143143
fileHandle, err := windows.CreateFile(name16, windows.GENERIC_WRITE|windows.DELETE, 0, sa, windows.CREATE_NEW, windows.FILE_ATTRIBUTE_TEMPORARY, 0)
144144
runtime.KeepAlive(sd)
145145
if err != nil {
146-
logger.Debug("Updater: Failed to create temporary file: %v (path: %s)", err, name)
146+
logger.Error("Updater: Failed to create temporary file: %v (path: %s)", err, name)
147147
return nil, fmt.Errorf("failed to create temporary file: %w", err)
148148
}
149149
logger.Debug("Updater: Temporary file created successfully")

0 commit comments

Comments
 (0)