fix: escape regex metacharacters in environment variable keys#1656
Open
Fikri-20 wants to merge 1 commit into
Open
fix: escape regex metacharacters in environment variable keys#1656Fikri-20 wants to merge 1 commit into
Fikri-20 wants to merge 1 commit into
Conversation
… substitution Environment variable keys containing regex metacharacters (., *, +, ?, [], etc.) caused FormatException crashes when used in request fields. This fix properly escapes all special characters using RegExp.escape() before building the regex pattern. - Fixed substituteVariables function in lib/utils/envvar_utils.dart - Added comprehensive test cases for special characters, regex metacharacters, and mixed character scenarios - Resolves crash when using environment variables like 'api.key', 'user+id', etc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1645
RegExp.escape()before being joined into the substitution regexFormatExceptionwhen any key contains unclosed metacharacters like(or[.,+,*(previously matched incorrectly due to unescaped regex semantics)Root Cause
substituteVariables()built a single regex from all active env var keys without escaping:One malformed key corrupts the regex for every request in that environment, silently freezing the Send button with no error shown.
Fix
Video for the app after resolve the bug
sol.mp4
now the current, and subsequent requests is sent appropriately!
Test plan
substituteVariablestests passapi(keyno longer freezes all requestsapi.keynow substitutes correctly (previously matched any char in place of.)