sniff magic bytes for application/octet-stream to select correct previewer#1678
Open
badnikhil wants to merge 1 commit into
Open
sniff magic bytes for application/octet-stream to select correct previewer#1678badnikhil wants to merge 1 commit into
badnikhil wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
This PR sniffs the first bytes of the response body using lookupMimeType from the mime package (already a transitive dependency via dio and share_plus) to detect the true format and route it to the correct previewer. The mime package is also added as a direct dependency to make the usage explicit.
The sniffing only applies when the declared type is exactly application/octet-stream and falls back gracefully if the format cannot be identified.
Sniffing is kept in the Previewer widget rather than the model layer because the sniffed type is a local rendering hint only, and i think moving it to the model would create an inconsistency between the persisted headers (which correctly reflect what the server sent) and the mediaType getter.
Related Issues
Checklist
mainbranch before making this PRflutter upgradeand verify)flutter test) and all tests are passingAdded/updated tests?
We encourage you to add relevant test cases.
OS on which you have developed and tested the feature?