Merge pull request #780 from fossa-app/validation-message-fix

tiksn · web-flow · commit 140190b37751 · 2025-09-28T23:23:30.000-05:00
Validation message fix
diff --git a/src/API.Core/Validators/EmployeeManagementCommandValidator.cs b/src/API.Core/Validators/EmployeeManagementCommandValidator.cs
@@ -48,7 +48,7 @@ public EmployeeManagementCommandValidator(
 
     RuleFor(x => x.ReportsToId)
       .MustAsync(ValidateReportsToIdNoCyclesAsync)
-      .WithMessage("ReportsToId must exist and belong to the same tenant");
+      .WithMessage("ReportsToId must not be cyclical.");
   }
 
   private async Task<bool> ValidateBranchAsync(EmployeeManagementCommand command, Option<BranchId> assignedBranchId, CancellationToken cancellationToken)
diff --git a/tests/API.FunctionalTests/ControllerApis/EmployeeControllerWithSystemLicense.cs b/tests/API.FunctionalTests/ControllerApis/EmployeeControllerWithSystemLicense.cs
@@ -420,7 +420,7 @@ private async Task<EmployeeRetrievalModel> CreateEmployeeAsync(HttpClient client
     var creationResponse = await client.PostAsJsonAsync("/api/1.0/Employee", new EmployeeModificationModel(firstName, lastName, $"{firstName} {lastName}"));
     if (creationResponse.StatusCode != HttpStatusCode.OK)
     {
-        _testOutputHelper.WriteLine(await creationResponse.Content.ReadAsStringAsync());
+      _testOutputHelper.WriteLine(await creationResponse.Content.ReadAsStringAsync());
     }
     creationResponse.StatusCode.ShouldBe(HttpStatusCode.OK);
 

Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ public EmployeeManagementCommandValidator(`
`48`	`48`
`49`	`49`	`RuleFor(x => x.ReportsToId)`
`50`	`50`	`.MustAsync(ValidateReportsToIdNoCyclesAsync)`
`51`		`- .WithMessage("ReportsToId must exist and belong to the same tenant");`
	`51`	`+ .WithMessage("ReportsToId must not be cyclical.");`
`52`	`52`	`}`
`53`	`53`
`54`	`54`	`private async Task<bool> ValidateBranchAsync(EmployeeManagementCommand command, Option<BranchId> assignedBranchId, CancellationToken cancellationToken)`
Original file line number	Diff line number	Diff line change
`@@ -420,7 +420,7 @@ private async Task<EmployeeRetrievalModel> CreateEmployeeAsync(HttpClient client`
`420`	`420`	`var creationResponse = await client.PostAsJsonAsync("/api/1.0/Employee", new EmployeeModificationModel(firstName, lastName, $"{firstName} {lastName}"));`
`421`	`421`	`if (creationResponse.StatusCode != HttpStatusCode.OK)`
`422`	`422`	`{`
`423`		`- _testOutputHelper.WriteLine(await creationResponse.Content.ReadAsStringAsync());`
	`423`	`+ _testOutputHelper.WriteLine(await creationResponse.Content.ReadAsStringAsync());`
`424`	`424`	`}`
`425`	`425`	`creationResponse.StatusCode.ShouldBe(HttpStatusCode.OK);`
`426`	`426`