Auto-determine derivations to build and update nix commands #85
Open
drupol wants to merge 1 commit into
Open
Conversation
Collaborator
Author
|
@jtojnar WDYT of this? Do you think it worth it ? |
drupol
force-pushed
the
ci/misc-update
branch
4 times, most recently
from
February 27, 2022 21:42
aebfa6a to
31f0ec3
Compare
drupol
changed the title
jtojnar
reviewed
Feb 28, 2022
jtojnar
left a comment
jtojnar
left a comment
Member
There was a problem hiding this comment.
Sounds like an interesting idea. We could probably even move most of the check out of workflows into tests.nix and have all the steps generated like in https://github.com/nix-community/poetry2nix/pull/472/files. Then we would also have convenient way to run the tests locally. (flake.nix can contain checks attribute in its output.
drupol
force-pushed
the
ci/misc-update
branch
2 times, most recently
from
February 28, 2022 10:54
b52f6a9 to
76b3a6a
Compare
drupol
marked this pull request as ready for review
February 28, 2022 18:13
Collaborator
Author
|
Ready for review now. |
Collaborator
Author
|
@jtojnar Any update on this? WDYT ? |
Member
|
As mentioned previously, I do not really like |
Test on Linux and MacOS.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test on Linux and MacOS.