Merge branch 'master' into status-d-fix

Author: GauravB159

src/Srclib/Types.hs

@@ -41,6 +41,7 @@ module Srclib.Types (
 ) where
 
 import Data.Aeson
+import Data.Char qualified as Char
 import Data.List.NonEmpty (NonEmpty ((:|)))
 import Data.List.NonEmpty qualified as NE
 import Data.Map (Map)
@@ -497,7 +498,10 @@ instance ToText Locator where
 
 renderLocator :: Locator -> Text
 renderLocator Locator{..} =
-  locatorFetcher <> "+" <> locatorProject <> "$" <> fromMaybe "" locatorRevision
+  stripNonPrintable $
+    locatorFetcher <> "+" <> locatorProject <> "$" <> fromMaybe "" locatorRevision
+  where
+    stripNonPrintable = Text.filter Char.isPrint
 
 -- The projectId is the full locator of the project. E.g. custom+123/someProject (<fetcher>+<orgId>/<project-name>)
 projectId :: Locator -> Text

test/Srclib/TypesSpec.hs

@@ -7,6 +7,7 @@ import Srclib.Types (
   SourceUnit (..),
   SourceUnitBuild (..),
   SourceUnitDependency (..),
+  renderLocator,
   toProjectLocator,
   translateSourceUnitLocators,
  )
@@ -15,6 +16,11 @@ import Types (GraphBreadth (Complete))
 
 spec :: Spec
 spec = do
+  describe "renderLocator" $ do
+    it "should strip non-printable characters such as NUL bytes" $ do
+      let locator = Locator "go" "github.com/gin-gonic\NUL/gin" (Just "v1.\t9.1\DEL")
+      renderLocator locator `shouldBe` "go+github.com/gin-gonic/gin$v1.9.1"
+
   describe "translateSourceUnitLocators" $ do
     -- Helper to create a simple translation function from a map (for backward compatibility in tests)
     let simpleTranslate translationMap loc =