Address CodeRabbit review round 5: pin deps, DetectionMethod::as_str()

- Pin dependency versions to match millhone for workspace consistency
- Add DetectionMethod::as_str() for parity with Primitive::as_str()
- Replace serde round-trip for DetectionMethod in cyclonedx.rs

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: CortezFrazierJr

extlib/cryptoscan/Cargo.toml

@@ -10,12 +10,12 @@ name = "cryptoscan"
 path = "src/main.rs"
 
 [dependencies]
-serde = { version = "1", features = ["derive"] }
-serde_json = "1"
+serde = { version = "1.0.183", features = ["derive"] }
+serde_json = "1.0.107"
 regex = "1"
-walkdir = "2"
-clap = { version = "4", features = ["derive"] }
-uuid = { version = "1", features = ["v4"] }
+walkdir = "2.4.0"
+clap = { version = "4.3.21", features = ["derive"] }
+uuid = { version = "1.4.1", features = ["v4"] }
 
 [dev-dependencies]
 tempfile = "3"

extlib/cryptoscan/src/crypto_algorithm.rs

@@ -103,6 +103,18 @@ pub enum DetectionMethod {
     StringLiteral,
 }
 
+impl DetectionMethod {
+    pub fn as_str(&self) -> &'static str {
+        match self {
+            DetectionMethod::DependencyManifest => "dependency-manifest",
+            DetectionMethod::ImportStatement => "import-statement",
+            DetectionMethod::ApiCall => "api-call",
+            DetectionMethod::ConfigFile => "config-file",
+            DetectionMethod::StringLiteral => "string-literal",
+        }
+    }
+}
+
 #[derive(Debug, Clone, Serialize, Deserialize, PartialEq)]
 #[serde(rename_all = "lowercase")]
 pub enum Confidence {

extlib/cryptoscan/src/cyclonedx.rs

@@ -170,10 +170,7 @@ pub fn to_cyclonedx_bom(findings: &[CryptoFinding]) -> CycloneDxBom {
                 });
             }
 
-            let method_str = serde_json::to_value(&finding.detection_method)
-                .ok()
-                .and_then(|v| v.as_str().map(|s| s.to_string()))
-                .unwrap_or_default();
+            let method_str = finding.detection_method.as_str().to_string();
             if seen_methods.insert(method_str.clone()) {
                 properties.push(BomProperty {
                     name: "fossa:detection-method".to_string(),