Skip to content

Commit 87ec1fe

Browse files
zlavclaude
andcommitted
Drop ServiceStack count rationale comment
The explanation for why the target count goes 64 to 92 belongs in the PR description, not in the integration test body. The test reads cleaner without nine lines of context above a one-line assertion. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 5348972 commit 87ec1fe

1 file changed

Lines changed: 0 additions & 9 deletions

File tree

integration-test/Analysis/NugetSpec.hs

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -45,15 +45,6 @@ testServiceStackForPkgReferences :: Spec
4545
testServiceStackForPkgReferences =
4646
aroundAll (withAnalysisOf NonStrict $ serviceStack NuGet.discover) $ do
4747
describe "ServiceStack" $ do
48-
-- 92 = every project file under v5.13.2 (91 .csproj + 1
49-
-- .fsproj). The pre-ANE-2523 expectation was 64; that count
50-
-- was masking the bug — 19 directories hold 2-3 sibling csproj
51-
-- files (e.g. src/ServiceStack/{ServiceStack, ServiceStack.Core,
52-
-- ServiceStack.Source}.csproj for the .NET-Framework /
53-
-- .NET-Core / source-distribution variants), and the old
54-
-- `find isPackageRefFile` was picking only one alphabetically
55-
-- and silently dropping the rest. Discovery now emits one
56-
-- NuGetProject per project file.
5748
it "should find targets" $ \(result, _) -> do
5849
length result `shouldBe` 92
5950

0 commit comments

Comments
 (0)