Skip to content

disable link-checks for creativecommons.org#1560

Merged
spatten merged 1 commit into
masterfrom
fix-creative-commons-linkchecks
Jul 7, 2025
Merged

disable link-checks for creativecommons.org#1560
spatten merged 1 commit into
masterfrom
fix-creative-commons-linkchecks

Conversation

@spatten

@spatten spatten commented Jul 7, 2025

Copy link
Copy Markdown
Contributor

Overview

creativecommons.org is using Cloudflare, so our link checks are always returning 403. You can see this with curl:

curl -I https://creativecommons.org/licenses/by/4.0/legalcode
HTTP/2 403 
date: Mon, 07 Jul 2025 22:51:42 GMT
content-type: text/html; charset=UTF-8
...
server: cloudflare
cf-ray: 95bae875aca80948-SEA

I turned off the link-checks for the two creativecommons.org links in our markdown docs, which should fix this.

Acceptance criteria

The markdown link checks pass

Testing plan

Risks

Maybe it would be better to do this by adding creativecommons.org to the ignore patterns .markdown-link-check.json, but I think I prefer that we ignore these wherever they are used

Metric

References

Checklist

  • I added tests for this PR's change (or explained in the PR description why tests don't make sense).
  • If this PR introduced a user-visible change, I added documentation into docs/.
  • If this PR added docs, I added links as appropriate to the user manual's ToC in docs/README.ms and gave consideration to how discoverable or not my documentation is.
  • If this change is externally visible, I updated Changelog.md. If this PR did not mark a release, I added my changes into an ## Unreleased section at the top.
  • If I made changes to .fossa.yml or fossa-deps.{json.yml}, I updated docs/references/files/*.schema.json AND I have updated example files used by fossa init command. You may also need to update these if you have added/removed new dependency type (e.g. pip) or analysis target type (e.g. poetry).
  • If I made changes to a subcommand's options, I updated docs/references/subcommands/<subcommand>.md.

@spatten spatten marked this pull request as ready for review July 7, 2025 23:00
@spatten spatten requested a review from a team as a code owner July 7, 2025 23:00
@spatten spatten requested a review from james-fossa July 7, 2025 23:00
@spatten spatten merged commit 4fbec2b into master Jul 7, 2025
19 checks passed
@spatten spatten deleted the fix-creative-commons-linkchecks branch July 7, 2025 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants