Conversation
nficca
commented
Aug 5, 2025
Contributor
Author
There was a problem hiding this comment.
These changes aren't relevant to the ticket. I just noticed we had a nix shell env and wanted to try it. It needed some updating to work on my mac, so these are that.
Contributor
Author
|
Closing this. I investigated the issue in https://fossa.atlassian.net/browse/ANE-1997 further and found that this is not the correct solution. See my comment here: https://fossa.atlassian.net/browse/ANE-1997?focusedCommentId=25189. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
In V3 package-lock files, fossa-cli is not filtering out transitive dev dependencies. This is because it is failing to recognize that transitive deps of dev dependencies are also dev dependencies.
Acceptance criteria
Transitive dev deps are correctly identified as dev deps and are filtered out of a project's dependencies list.
Testing plan
package.jsonfile attached to ANE-1997.npm installin the directory with the package.json to build the project.fossa-clion the directory@angular-devkit/build-angularare listedfossa-clion the directory@angular-devkit/build-angularare NOT listedRisks
Could miscategorize dependencies if there is a bug in this logic.
References
Checklist
docs/.docs/README.msand gave consideration to how discoverable or not my documentation is.Changelog.md. If this PR did not mark a release, I added my changes into an## Unreleasedsection at the top..fossa.ymlorfossa-deps.{json.yml}, I updateddocs/references/files/*.schema.jsonAND I have updated example files used byfossa initcommand. You may also need to update these if you have added/removed new dependency type (e.g.pip) or analysis target type (e.g.poetry).docs/references/subcommands/<subcommand>.md.