[ANE-2484][ANE-2503] Actually call Ficus, use --x-snippet-scan as a flag.#1573
Merged
Conversation
* scan all layers for os info * add test * lint * accidently on purposed * whitespace * typo * update changelog * no need to log * prepare for release
…ts to be coherent.
Now we're cooking with gas:
```
Running Ficus analysis on /Users/jclemer/wam/
[DEBUG] Executing ficus
[DEBUG] Ficus returned 4 errors, 0 debug messages, 1 findings
[WARN] ERROR fingerprint: Read(
Custom {
kind: InvalidData,
error: "binary file detected: /Users/jclemer/wam/.git/index",
},
)
[WARN] ERROR fingerprint: Read(
Custom {
kind: InvalidData,
error: "binary file detected: /Users/jclemer/wam/.git/objects/pack/pack-183ce412024750728f9349e31668d39ee389840e.idx",
},
)
[WARN] ERROR fingerprint: Read(
Custom {
kind: InvalidData,
error: "binary file detected: /Users/jclemer/wam/.git/objects/pack/pack-183ce412024750728f9349e31668d39ee389840e.pack",
},
)
[WARN] ERROR fingerprint: Read(
Custom {
kind: InvalidData,
error: "binary file detected: /Users/jclemer/wam/.git/objects/pack/pack-183ce412024750728f9349e31668d39ee389840e.rev",
},
)
FINDING fingerprint: {"analysis_id":15}
Ficus analysis completed successfully with analysis ID: 15
```
james-fossa
force-pushed
the
ane-2484-call-ficus
branch
from
48f3397 to
86268be
Compare
james-fossa
force-pushed
the
ane-2484-call-ficus
branch
from
86268be to
333b403
Compare
james-fossa
force-pushed
the
ane-2484-call-ficus
branch
2 times, most recently
from
dc007df to
0ab11ad
Compare
james-fossa
added a commit
that referenced
this pull request
Aug 11, 2025
* [ANE-2484] Download ficus in vendor_download.sh * [ANE-2484] Listen to shellcheck's wisdom * [ANE-2484][ANE-2503] Actually call Ficus, use `--x-snippet-scan` as a flag. (#1573) * gradle: exclude constraints when retrieving dependencies (#1563) * [ane-2575] scan all layers for os info (#1566) * scan all layers for os info * add test * lint * accidently on purposed * whitespace * typo * update changelog * no need to log * prepare for release * WIP * WIP * Get ficus wired in and at least vaguely tested. More to do to get tests to be coherent. Now we're cooking with gas: ``` Running Ficus analysis on /Users/jclemer/wam/ [DEBUG] Executing ficus [DEBUG] Ficus returned 4 errors, 0 debug messages, 1 findings [WARN] ERROR fingerprint: Read( Custom { kind: InvalidData, error: "binary file detected: /Users/jclemer/wam/.git/index", }, ) [WARN] ERROR fingerprint: Read( Custom { kind: InvalidData, error: "binary file detected: /Users/jclemer/wam/.git/objects/pack/pack-183ce412024750728f9349e31668d39ee389840e.idx", }, ) [WARN] ERROR fingerprint: Read( Custom { kind: InvalidData, error: "binary file detected: /Users/jclemer/wam/.git/objects/pack/pack-183ce412024750728f9349e31668d39ee389840e.pack", }, ) [WARN] ERROR fingerprint: Read( Custom { kind: InvalidData, error: "binary file detected: /Users/jclemer/wam/.git/objects/pack/pack-183ce412024750728f9349e31668d39ee389840e.rev", }, ) FINDING fingerprint: {"analysis_id":15} Ficus analysis completed successfully with analysis ID: 15 ``` * Fixing up formatting * [ANE-2484] Add ficus to extra-source files * Fix FICUS_ASSET_POSTFIX to match changed release * Fix Windows postfix for changed release * Change themis arch in suffix --------- Co-authored-by: Jeremy Gonzalez <jeremy@fossa.com> * Caveperson debug vendor_download --------- Co-authored-by: Jeremy Gonzalez <jeremy@fossa.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Calls ficus, uses the
analysis_idas the query paramsnippetAnalysisIdinuploadAnalysis&co.Acceptance criteria
Testing plan
So far mostly through manual testing. I still aim to get a better integration testing story, but that can happen during review. I'm quite open to suggestions.
Risks
I think the error handling is a little weak here. Again open to guidance.
Metrics
N/A
References
Checklist
docs/.docs/README.msand gave consideration to how discoverable or not my documentation is.Changelog.md. If this PR did not mark a release, I added my changes into an## Unreleasedsection at the top..fossa.ymlorfossa-deps.{json.yml}, I updateddocs/references/files/*.schema.jsonAND I have updated example files used byfossa initcommand. You may also need to update these if you have added/removed new dependency type (e.g.pip) or analysis target type (e.g.poetry).docs/references/subcommands/<subcommand>.md.