Replace broken eastwood Clojure fixture with clj-http#1710
Conversation
Analysis.Clojure.eastwood has been failing because the pinned eastwood Release-1.0.0 tarball ships a secondary project.clj at .circleci/nvd/ whose OWASP dependency-check transitive deps are no longer resolvable from Maven Central / Clojars. Newer eastwood tags ship even more nested example projects, so bumping the tag doesn't help. Replace eastwood with clj-http 3.13.1, which has a single project.clj at the root and depends only on widely-mirrored Apache HttpComponents and commons artifacts. Dependency counts are placeholder values; will be updated once CI reports the real numbers. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Resolved locally with leiningen 2.12.0 + Java 25 against the pinned clj-http 3.13.1 tarball: 71 deps, 27 direct, 44 edges, 1 manifest. The dev-profile dependencies are included by `lein deps :tree-data`, which explains the count being larger than the 9 production deps in project.clj. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
WalkthroughThis PR updates FOSSA CLI to version 3.17.6 and modifies the Clojure analysis test suite. The changelog documents a fix for two incorrect GPL license matches. The integration test file replaces the eastwood Leiningen test fixture with a new clj-http fixture, including fixture definition and corresponding test dependency summary updates to reflect the new test artifact. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@integration-test/Analysis/ClojureSpec.hs`:
- Line 43: The DependencyResultsSummary values in the test assertion (the line
calling testSuiteDepResultSummary NonStrict cljHttp LeiningenProjectType
(DependencyResultsSummary 71 27 44 1 Complete)) are placeholders that must match
CI; run the Integration Tests workflow, confirm the dependency counts CI reports
for DependencyResultsSummary (total, direct, edges, manifests), and update the
tuple in that test assertion to the exact CI numbers if they differ, then re-run
the Integration Tests to ensure the workflow passes before merging.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Pro
Run ID: 1172019a-2d27-48eb-8aba-2e080279589c
📒 Files selected for processing (2)
Changelog.mdintegration-test/Analysis/ClojureSpec.hs
Overview
Analysis.Clojure.eastwoodhas been failing on master because the pinned eastwoodRelease-1.0.0tarball ships a secondaryproject.cljunder.circleci/nvd/whose OWASPdependency-checktransitive deps are no longer resolvable from Maven Central / Clojars. Newer eastwood tags ship even more nested example projects, so bumping the tag doesn't help.This PR replaces the eastwood fixture with
clj-http 3.13.1, which has a singleproject.cljat the root and depends only on widely-mirrored Apache HttpComponents and commons artifacts.Acceptance criteria
Analysis.Clojure.clj-httpandAnalysis.Clojure.ringpass in the Integration Tests workflow.Testing plan
CI integration-tests run on this branch goes green for the Clojure tests.
Risks
The dependency-count assertion (
DependencyResultsSummary) is currently a placeholder; needs to be updated with the real numbers reported by CI before this is ready to merge.References
Supersedes #1709.
Checklist
docs/. Not user-visible.docs/README.msand gave consideration to how discoverable or not my documentation is.Changelog.md. Not externally visible..fossa.ymlorfossa-deps.{json.yml}, I updateddocs/references/files/*.schema.jsonAND I have updated example files used byfossa initcommand.docs/references/subcommands/<subcommand>.md.