Skip to content

Replace broken eastwood Clojure fixture with clj-http#1710

Merged
spatten merged 3 commits into
masterfrom
scott/replace-eastwood-fixture
May 12, 2026
Merged

Replace broken eastwood Clojure fixture with clj-http#1710
spatten merged 3 commits into
masterfrom
scott/replace-eastwood-fixture

Conversation

@spatten

@spatten spatten commented May 12, 2026

Copy link
Copy Markdown
Contributor

Overview

Analysis.Clojure.eastwood has been failing on master because the pinned eastwood Release-1.0.0 tarball ships a secondary project.clj under .circleci/nvd/ whose OWASP dependency-check transitive deps are no longer resolvable from Maven Central / Clojars. Newer eastwood tags ship even more nested example projects, so bumping the tag doesn't help.

This PR replaces the eastwood fixture with clj-http 3.13.1, which has a single project.clj at the root and depends only on widely-mirrored Apache HttpComponents and commons artifacts.

Acceptance criteria

Analysis.Clojure.clj-http and Analysis.Clojure.ring pass in the Integration Tests workflow.

Testing plan

CI integration-tests run on this branch goes green for the Clojure tests.

Risks

The dependency-count assertion (DependencyResultsSummary) is currently a placeholder; needs to be updated with the real numbers reported by CI before this is ready to merge.

References

Supersedes #1709.

Checklist

  • I added tests for this PR's change (or explained in the PR description why tests don't make sense). This is a test-fixture replacement; the integration test it repairs is the test.
  • If this PR introduced a user-visible change, I added documentation into docs/. Not user-visible.
  • If this PR added docs, I added links as appropriate to the user manual's ToC in docs/README.ms and gave consideration to how discoverable or not my documentation is.
  • If this change is externally visible, I updated Changelog.md. Not externally visible.
  • If I made changes to .fossa.yml or fossa-deps.{json.yml}, I updated docs/references/files/*.schema.json AND I have updated example files used by fossa init command.
  • If I made changes to a subcommand's options, I updated docs/references/subcommands/<subcommand>.md.

Analysis.Clojure.eastwood has been failing because the pinned eastwood
Release-1.0.0 tarball ships a secondary project.clj at .circleci/nvd/
whose OWASP dependency-check transitive deps are no longer resolvable
from Maven Central / Clojars. Newer eastwood tags ship even more
nested example projects, so bumping the tag doesn't help.

Replace eastwood with clj-http 3.13.1, which has a single project.clj
at the root and depends only on widely-mirrored Apache HttpComponents
and commons artifacts.

Dependency counts are placeholder values; will be updated once CI
reports the real numbers.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Resolved locally with leiningen 2.12.0 + Java 25 against the pinned
clj-http 3.13.1 tarball: 71 deps, 27 direct, 44 edges, 1 manifest. The
dev-profile dependencies are included by `lein deps :tree-data`, which
explains the count being larger than the 9 production deps in
project.clj.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

@zlav zlav left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@spatten spatten marked this pull request as ready for review May 12, 2026 23:30
@spatten spatten requested a review from a team as a code owner May 12, 2026 23:30
@spatten spatten requested a review from tjugdev May 12, 2026 23:30
@spatten spatten enabled auto-merge (squash) May 12, 2026 23:30
@coderabbitai

coderabbitai Bot commented May 12, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

This PR updates FOSSA CLI to version 3.17.6 and modifies the Clojure analysis test suite. The changelog documents a fix for two incorrect GPL license matches. The integration test file replaces the eastwood Leiningen test fixture with a new clj-http fixture, including fixture definition and corresponding test dependency summary updates to reflect the new test artifact.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately and specifically describes the main change: replacing the eastwood fixture with clj-http in the Clojure test suite.
Description check ✅ Passed The PR description comprehensively covers all template sections with concrete details about the problem, solution, testing plan, and known risks.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@integration-test/Analysis/ClojureSpec.hs`:
- Line 43: The DependencyResultsSummary values in the test assertion (the line
calling testSuiteDepResultSummary NonStrict cljHttp LeiningenProjectType
(DependencyResultsSummary 71 27 44 1 Complete)) are placeholders that must match
CI; run the Integration Tests workflow, confirm the dependency counts CI reports
for DependencyResultsSummary (total, direct, edges, manifests), and update the
tuple in that test assertion to the exact CI numbers if they differ, then re-run
the Integration Tests to ensure the workflow passes before merging.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro

Run ID: 1172019a-2d27-48eb-8aba-2e080279589c

📥 Commits

Reviewing files that changed from the base of the PR and between ae690f8 and c0caea7.

📒 Files selected for processing (2)
  • Changelog.md
  • integration-test/Analysis/ClojureSpec.hs

Comment thread integration-test/Analysis/ClojureSpec.hs
@spatten spatten merged commit 56cc319 into master May 12, 2026
19 checks passed
@spatten spatten deleted the scott/replace-eastwood-fixture branch May 12, 2026 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants