fix: address sourcery-ai review comments

- Updated MockHandler.open to use the port argument.
- Clarified partial read behavior in MockHandler.read.
- Added safety check in ScienceLab to prevent mixed device/mock arguments.

Author: hitarthium

pslab/mock_handler.py

@@ -23,9 +23,16 @@ def __init__(self, port: Optional[str] = None):
         self.logger = logging.getLogger(__name__)
 
     def open(self, port: Optional[str] = None) -> None:
+        """
+        Simulate opening the connection.
+        
+        Args:
+            port (str, optional): The port to connect to. Updates the handler's port if provided.
+        """
+        if port:
+            self.port = port
         self.connected = True
         self.logger.info(f"MockHandler connected on {self.port}")
-
     def close(self) -> None:
         self.connected = False
         self.read_buffer.clear()
@@ -52,6 +59,17 @@ def read(self, size: int = 1) -> bytes:
         if not self.connected:
             raise RuntimeError("Attempted to read from closed MockHandler.")
 
+        if len(self.read_buffer) < size:
+            self.logger.warning(f"MockHandler: Requested {size} bytes, but only {len(self.read_buffer)} available.")
+            # Return all currently available bytes and clear the buffer (partial read)
+            data = self.read_buffer[:]
+            self.read_buffer.clear()
+            return bytes(data)
+
+        data = self.read_buffer[:size]
+        self.read_buffer = self.read_buffer[size:]
+        return bytes(data)
+
         if len(self.read_buffer) < size:
             self.logger.warning(f"MockHandler: Requested {size} bytes, but only {len(self.read_buffer)} available.")
             # Return what we have, then empty bytes

pslab/sciencelab.py

@@ -35,7 +35,17 @@ class ScienceLab:
     """
 
     def __init__(self, device: ConnectionHandler | None = None, mock: bool = False):
+        """
+        Initialize the ScienceLab interface.
+        
+        :param device: The connection handler (real hardware).
+        :param mock: If True, use the MockHandler for simulation.
+        :raises ValueError: If both 'device' and 'mock=True' are provided.
+        """
         if mock:
+            if device is not None:
+                raise ValueError("Cannot initialize ScienceLab with both a physical device and mock=True.")
+            
             self.device = MockHandler()
             self.device.open()
             self.firmware = "MOCK_FW_1.0" # Fake firmware version