Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion fastsafetensors/common.py
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ def __init__(
self.framework = framework
ser = json.loads(string, object_pairs_hook=OrderedDict)
self.metadata = ser.get("__metadata__", "")
if self.metadata:
if "__metadata__" in ser:
del ser["__metadata__"]
self.tensors: Dict[str, TensorFrame] = {}
self.header_length = header_length
Expand Down
17 changes: 17 additions & 0 deletions tests/unit/test_fastsafetensors.py
Original file line number Diff line number Diff line change
Expand Up @@ -950,6 +950,23 @@ def dribbling_read(fd: int, length: int) -> bytes:
assert meta.tensors["a0"].shape == [4, 8]


def test_from_file_empty_metadata(tmp_dir, framework) -> None:
# Regression test: a safetensors file whose header carries an empty
# __metadata__: {} object must parse without raising. Previously,
# __metadata__ was stripped only when truthy, so {} survived into the
# tensor sort and raised KeyError: 'data_offsets' (see e.g. loading
# MiniMaxAI/MiniMax-M3-MXFP8 via vLLM --load-format fastsafetensors).
device, _ = get_and_check_device(framework)
filename = os.path.join(tmp_dir, "empty_metadata.safetensors")
a0 = framework.randn((4, 8), device=device, dtype=DType.F32)
save_safetensors_file({"a0": a0.get_raw()}, filename, {}, framework)

meta = SafeTensorsMetadata.from_file(filename, framework)
assert "a0" in meta.tensors
assert meta.tensors["a0"].shape == [4, 8]
assert meta.metadata == {}


def test_no_module_level_torch_import_outside_frameworks() -> None:
# Policy: framework-specific imports live behind the frameworks
# abstraction. Only the torch backend (frameworks/_torch.py) may import
Expand Down
Loading