Skip to content

Commit 060e601

Browse files
fixup! fix: yaml parsing converts floats like 1.0 into integer 1 causing assertion failure
Signed-off-by: Harikrishnan Balagopal <harikrishmenon@gmail.com>
1 parent d32ca90 commit 060e601

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

tuning/data/data_config.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -101,6 +101,7 @@ def _validate_dataset_config(dataset_config) -> DataSetConfig:
101101
if "sampling" in kwargs and kwargs["sampling"] is not None:
102102
ratio = kwargs["sampling"]
103103
if isinstance(ratio, int):
104+
# YAML parsing causes 1.0 (float) to be cast to 1 (int) causing assertion error
104105
ratio = float(ratio)
105106
assert isinstance(ratio, float) and (
106107
0 <= ratio <= 1.0

0 commit comments

Comments
 (0)