fixup! fixup! fix: only trigger on_save if the output checkpoint path actually contains files

HarikrishnanBalagopal · HarikrishnanBalagopal · commit 06f28ea2b67b · 2026-01-20T15:44:14.000+05:30
Signed-off-by: Harikrishnan Balagopal &lt;harikrishmenon@gmail.com&gt;
diff --git a/tuning/sft_trainer.py b/tuning/sft_trainer.py
@@ -587,7 +587,7 @@ def save(path: str, trainer: SFTTrainer, tc_callback, log_level="WARNING", args=
                     path,
                 )
                 actually_saved = len(saved_files) > 0
-            except Exception as e:
+            except Exception as e:  # pylint: disable-next=broad-exception-caught
                 logger.warning(
                     "sanity check, failed to list files in checkpoint path '%s' , error: %s",
                     path,

Original file line number	Diff line number	Diff line change
`@@ -587,7 +587,7 @@ def save(path: str, trainer: SFTTrainer, tc_callback, log_level="WARNING", args=`
`587`	`587`	`path,`
`588`	`588`	`)`
`589`	`589`	`actually_saved = len(saved_files) > 0`
`590`		`- except Exception as e:`
	`590`	`+ except Exception as e: # pylint: disable-next=broad-exception-caught`
`591`	`591`	`logger.warning(`
`592`	`592`	`"sanity check, failed to list files in checkpoint path '%s' , error: %s",`
`593`	`593`	`path,`