Skip to content

Commit 81adf10

Browse files
fix: yaml parsing converts floats like 1.0 into integer 1 causing assertion failure
Signed-off-by: Harikrishnan Balagopal <harikrishmenon@gmail.com>
1 parent b826c18 commit 81adf10

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

tuning/data/data_config.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,9 @@ def _validate_dataset_config(dataset_config) -> DataSetConfig:
100100
c.builder = builder
101101
if "sampling" in kwargs and kwargs["sampling"] is not None:
102102
ratio = kwargs["sampling"]
103+
if isinstance(ratio, int):
104+
# YAML parsing causes 1.0 (float) to be cast to 1 (int) causing assertion error
105+
ratio = float(ratio)
103106
assert isinstance(ratio, float) and (
104107
0 <= ratio <= 1.0
105108
), f"sampling ratio: {ratio} should be float and in range [0.0,1.0]"

0 commit comments

Comments
 (0)