fix: exclude modules (requires peft update)

Signed-off-by: Will Johnson <mwjohnson728@gmail.com>

Author: willmj

pyproject.toml

@@ -35,7 +35,7 @@ dependencies = [
 "tokenizers>=0.13.3,<1.0",
 "tqdm>=4.66.2,<5.0",
 "trl>=0.13,<0.18",
-"peft>=0.8.0,<0.14",
+"peft>=0.8.0,<0.15",
 "protobuf>=5.28.0,<6.0.0",
 "datasets>=2.15.0,<4.0",
 "simpleeval>=0.9.13,<2.0",

tuning/sft_trainer.py

@@ -167,6 +167,7 @@ def train(
                 "`--padding_free` argument was called with `packing=True`, "
                 "Trainer should not perform packing when using `--padding_free`"
             )
+    except_modules = False
     if fast_moe_config is not None and fast_moe_config.fast_moe is None:
         fast_moe_config = None
     if fast_moe_config is not None:
@@ -177,7 +178,7 @@ def train(
             and hasattr(peft_config, "target_modules")
             and fast_moe_config.fast_moe is not None
         ):
-            peft_config.exclude_modules = "router"
+            except_modules = True
             logger.warning(
                 "You are running lora with the ScatterMoE plugin, please note that "
                 "passing target modules that are part of the moe module can cause unexpected "
@@ -315,6 +316,9 @@ def train(
         ),
     )
 
+    if except_modules:
+        peft_config.exclude_modules = "router"
+
     if data_args.chat_template:
         # TODO: passing "/n" through cli causes parsing issues,
         # hence providing a temporary fix