fix: (data pre-process) un-escape templates and strings passed on cli correctly#493
Merged
dushyantbehl merged 2 commits intofoundation-model-stack:mainfrom Apr 8, 2025
Conversation
ChanderG
requested review from
Ssukriti,
aluu317,
anhuong,
fabianlim and
kmehant
as code owners
|
Thanks for making a pull request! 😃 |
Contributor
Author
|
I have tested the change locally with the original dataset that caused the problem. |
ChanderG
changed the title
kmehant
changed the title
Signed-off-by: Dushyant Behl <dushyantbehl@in.ibm.com> Signed-off-by: ChanderG <mail@chandergovind.org>
ChanderG
force-pushed
the
bugfix-492-response-template
branch
from
7fa8b92 to
4dab678
Compare
dushyantbehl
changed the title
2 tasks
dushyantbehl
added a commit
to dushyantbehl/fms-hf-tuning
that referenced
this pull request
Jun 23, 2025
Signed-off-by: Dushyant Behl <dushyantbehl@in.ibm.com> Signed-off-by: ChanderG <mail@chandergovind.org> Co-authored-by: Dushyant Behl <dushyantbehl@in.ibm.com> Co-authored-by: Dushyant Behl <dushyantbehl@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #492
Description of the change
Related issue number
#492
How to verify the PR
Was the PR tested