fix: additional special tokens being replaced#517
Merged
dushyantbehl merged 2 commits intofoundation-model-stack:mainfrom Apr 4, 2025
Merged
fix: additional special tokens being replaced#517dushyantbehl merged 2 commits intofoundation-model-stack:mainfrom
dushyantbehl merged 2 commits intofoundation-model-stack:mainfrom
Conversation
|
Thanks for making a pull request! 😃 |
ashokponkumar
previously approved these changes
Apr 4, 2025
Signed-off-by: Dushyant Behl <dushyantbehl@in.ibm.com>
ashokponkumar
approved these changes
Apr 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
While adding additional special tokens it was noticed that the existing special tokens were being replaced and not present this was due to the fact that when calling add_special_tokens the argument replace_additional_special_tokens was being set to
Trueby default and was causing the issue.Note the HF documentation of this function states
Which means model accuracy and performance before this fix was not going to be affected but to fix the desired behavior this change sets
replace_additional_special_tokens=FalseAlso adds a test case to check this internally.
Related issue number
How to verify the PR
Was the PR tested