fix:Add tiny granite vision model and update ReadMe for vision model support.#533
Merged
Merged
Conversation
Signed-off-by: Abhishek <maurya.abhishek@ibm.com>
Signed-off-by: Abhishek <maurya.abhishek@ibm.com>
Signed-off-by: Abhishek <maurya.abhishek@ibm.com>
Abhishek-TAMU
requested review from
aluu317,
anhuong,
dushyantbehl,
fabianlim and
kmehant
as code owners
|
Thanks for making a pull request! 😃 |
Collaborator
Author
|
@dushyantbehl Addition of tiny vision models and image dataset file in this PR would also be used in further v2 work in writing end-to-end unit test case as currently I couldn't write e2e test case as we just accept PIL format image as input and in v2 plan to accept PNG and JPEG image format. |
| ### Constants used for model path | ||
| PREDEFINED_MODEL_PATH = os.path.join(os.path.dirname(__file__)) | ||
| LLAMA_VISION_MODEL_NAME = os.path.join(PREDEFINED_MODEL_PATH, "tiny_llama_vision_model") | ||
| GRANITE_VISION_MODEL_NAME = os.path.join( |
Collaborator
There was a problem hiding this comment.
Suggested change
| GRANITE_VISION_MODEL_NAME = os.path.join( | |
| TINY_GRANITE_VISION_MODEL_NAME = os.path.join( |
Collaborator
There was a problem hiding this comment.
similarly for llama to tiny llama
| ### Constants used for model path | ||
| PREDEFINED_MODEL_PATH = os.path.join(os.path.dirname(__file__)) | ||
| LLAMA_VISION_MODEL_NAME = os.path.join(PREDEFINED_MODEL_PATH, "tiny_llama_vision_model") | ||
| GRANITE_VISION_MODEL_NAME = os.path.join( |
Collaborator
There was a problem hiding this comment.
similarly for llama to tiny llama
Signed-off-by: Abhishek <maurya.abhishek@ibm.com>
dushyantbehl
previously approved these changes
Apr 22, 2025
Collaborator
dushyantbehl
left a comment
dushyantbehl
left a comment
There was a problem hiding this comment.
LGTM! Thanks @Abhishek-TAMU
@willmj up to you to merge post the tests pass.
Signed-off-by: Abhishek <maurya.abhishek@ibm.com>
willmj
approved these changes
Apr 22, 2025
dushyantbehl
pushed a commit
to dushyantbehl/fms-hf-tuning
that referenced
this pull request
Jun 23, 2025
…support. (foundation-model-stack#533) * Update readme and fix Signed-off-by: Abhishek <maurya.abhishek@ibm.com> * Assign use_cache for vision model Signed-off-by: Abhishek <maurya.abhishek@ibm.com> * tiny granite vision model and dataset with doc change Signed-off-by: Abhishek <maurya.abhishek@ibm.com> * fix * Change GRANITE_VISION_MODEL_NAME to TINY_GRANITE_VISION_MODEL_NAME Signed-off-by: Abhishek <maurya.abhishek@ibm.com> * fmt/lint fix Signed-off-by: Abhishek <maurya.abhishek@ibm.com> --------- Signed-off-by: Abhishek <maurya.abhishek@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
Fix for supporting vision model tuning.
Changes:
Related issue number
Issue: https://github.ibm.com/ai-foundation/watson-fm-stack-tracker/issues/1610
How to verify the PR
Was the PR tested