fix: yaml parsing converts floats like 1.0 into integer 1 causing assertion failure#536
Merged
dushyantbehl merged 3 commits intoApr 25, 2025
Conversation
HarikrishnanBalagopal
requested review from
aluu317,
anhuong,
dushyantbehl,
fabianlim and
kmehant
as code owners
|
Thanks for making a pull request! 😃 |
HarikrishnanBalagopal
force-pushed
the
fix/sampling
branch
from
060e601 to
81adf10
Compare
dushyantbehl
requested changes
Apr 24, 2025
Collaborator
dushyantbehl
left a comment
dushyantbehl
left a comment
There was a problem hiding this comment.
Please update PR description with the error you encountered and the reason to fix this.
…ertion failure Signed-off-by: Harikrishnan Balagopal <harikrishmenon@gmail.com>
HarikrishnanBalagopal
force-pushed
the
fix/sampling
branch
from
81adf10 to
115f0a8
Compare
dushyantbehl
added a commit
to dushyantbehl/fms-hf-tuning
that referenced
this pull request
Jun 23, 2025
…ertion failure (foundation-model-stack#536) Signed-off-by: Harikrishnan Balagopal <harikrishmenon@gmail.com> Co-authored-by: Dushyant Behl <dushyantbehl@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
Yaml parsing converts floats like 1.0 into integer 1 causing assertion failure of sampling ratio. This patch fixes the assertion condition.
Related issue number
How to verify the PR
Was the PR tested