From 115f0a8d0b55d0d9936cc82b55463173168b8a04 Mon Sep 17 00:00:00 2001 From: Harikrishnan Balagopal Date: Thu, 24 Apr 2025 10:52:36 +0530 Subject: [PATCH] fix: yaml parsing converts floats like 1.0 into integer 1 causing assertion failure Signed-off-by: Harikrishnan Balagopal --- tuning/data/data_config.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tuning/data/data_config.py b/tuning/data/data_config.py index c695f82d5b..f132e611c7 100644 --- a/tuning/data/data_config.py +++ b/tuning/data/data_config.py @@ -100,10 +100,11 @@ def _validate_dataset_config(dataset_config) -> DataSetConfig: c.builder = builder if "sampling" in kwargs and kwargs["sampling"] is not None: ratio = kwargs["sampling"] - assert isinstance(ratio, float) and ( - 0 <= ratio <= 1.0 + # YAML parsing causes 1.0 (float) to be cast to 1 (int) + assert isinstance(ratio, (float, int)) and ( + 0.0 <= ratio <= 1.0 ), f"sampling ratio: {ratio} should be float and in range [0.0,1.0]" - c.sampling = ratio + c.sampling = float(ratio) if "rename_columns" in kwargs and kwargs["rename_columns"] is not None: rename = kwargs["rename_columns"] assert isinstance(