chore(deps): upgrade trl#537
Merged
dushyantbehl merged 4 commits intoApr 25, 2025
Merged
Conversation
Signed-off-by: Will Johnson <mwjohnson728@gmail.com>
willmj
requested review from
aluu317,
anhuong,
dushyantbehl,
fabianlim and
kmehant
as code owners
|
Thanks for making a pull request! 😃 |
willmj
force-pushed
the
deps-upgrade-trl
branch
2 times, most recently
from
917492c to
3803ecc
Compare
willmj
force-pushed
the
deps-upgrade-trl
branch
from
0dfb7e6 to
4041a7b
Compare
Collaborator
Collaborator
|
@willmj Before merging feel free to share your conclusion on padding_free tuning test with TRL v0.17 here. |
willmj
force-pushed
the
deps-upgrade-trl
branch
from
0befd5f to
4041a7b
Compare
Signed-off-by: Will Johnson <mwjohnson728@gmail.com>
dushyantbehl
approved these changes
Apr 25, 2025
Collaborator
dushyantbehl
left a comment
dushyantbehl
left a comment
There was a problem hiding this comment.
Looks Good. Thanks @willmj @Abhishek-TAMU
dushyantbehl
merged commit 6fc9f46
into
foundation-model-stack:main
4 of 9 checks passed
dushyantbehl
added a commit
that referenced
this pull request
Apr 25, 2025
This reverts commit 6fc9f46.
dushyantbehl
added a commit
that referenced
this pull request
Apr 25, 2025
This reverts commit 6fc9f46. Signed-off-by: Dushyant Behl <dushyantbehl@in.ibm.com>
dushyantbehl
added a commit
that referenced
this pull request
Apr 25, 2025
dushyantbehl
added a commit
to dushyantbehl/fms-hf-tuning
that referenced
this pull request
Jun 23, 2025
* deps: upgrade trl Signed-off-by: Will Johnson <mwjohnson728@gmail.com> * docs: offline data preprocessing note Signed-off-by: Will Johnson <mwjohnson728@gmail.com> --------- Signed-off-by: Will Johnson <mwjohnson728@gmail.com> Co-authored-by: Dushyant Behl <dushyantbehl@users.noreply.github.com>
dushyantbehl
added a commit
to dushyantbehl/fms-hf-tuning
that referenced
this pull request
Jun 23, 2025
…ation-model-stack#539) This reverts commit 6fc9f46. Signed-off-by: Dushyant Behl <dushyantbehl@in.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
Update trl
Related issue number
How to verify the PR
Was the PR tested