fix: incorrect check on fast moe activation#544
Merged
dushyantbehl merged 1 commit intofoundation-model-stack:mainfrom Apr 29, 2025
Merged
fix: incorrect check on fast moe activation#544dushyantbehl merged 1 commit intofoundation-model-stack:mainfrom
dushyantbehl merged 1 commit intofoundation-model-stack:mainfrom
Conversation
kmehant
requested review from
aluu317,
anhuong,
dushyantbehl and
fabianlim
as code owners
|
Thanks for making a pull request! 😃 |
Signed-off-by: Mehant Kammakomati <mehant.kammakomati2@ibm.com>
dushyantbehl
pushed a commit
to dushyantbehl/fms-hf-tuning
that referenced
this pull request
Jun 23, 2025
Signed-off-by: Mehant Kammakomati <mehant.kammakomati2@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incorrect check leading to unnecessary lora checks to non fast moe runs. Introduced in #530