fix: Config save cleanup#113
Merged
andrea-fasoli merged 6 commits intofoundation-model-stack:mainfrom May 10, 2025
Merged
Conversation
BrandonGroth
requested review from
andrea-fasoli,
chichun-charlie-liu,
kcirred,
nwang-ibm and
tharapalanivel
as code owners
chichun-charlie-liu
approved these changes
May 8, 2025
Signed-off-by: Brandon Groth <brandon.m.groth@gmail.com>
…, and added smoothq vars to default config Signed-off-by: Brandon Groth <brandon.m.groth@gmail.com>
Signed-off-by: Brandon Groth <brandon.m.groth@gmail.com>
Signed-off-by: Brandon Groth <brandon.m.groth@gmail.com>
Signed-off-by: Brandon Groth <brandon.m.groth@gmail.com>
Signed-off-by: Brandon Groth <brandon.m.groth@gmail.com>
BrandonGroth
force-pushed
the
config_save_cleanup
branch
from
3a5b01b to
02535d1
Compare
tharapalanivel
approved these changes
May 9, 2025
|
|
||
| save_json(config_list, file_path="qcfg.json") | ||
|
|
||
| with pytest.raises(ValueError): |
Collaborator
There was a problem hiding this comment.
nit: tiny comment is to actually check that it fails Quantized config={fname} is not a dictionary but optional
Collaborator
Author
There was a problem hiding this comment.
Maybe I am missing something, but I setup qconfig_load to only accept a dict datatype from the json.load, or it errors. So this check should force an error.
andrea-fasoli
approved these changes
May 10, 2025
Collaborator
andrea-fasoli
left a comment
andrea-fasoli
left a comment
There was a problem hiding this comment.
looks good to me, ready to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR fixes issues found with the config_save feature added in #103:
Was the PR tested