feat: AIU sim for FP8 (DL8/DL16) added to triton kernel#159
Merged
chichun-charlie-liu merged 13 commits intofoundation-model-stack:mainfrom Jul 10, 2025
Merged
Conversation
Signed-off-by: cliu-us <cliu@us.ibm.com>
Signed-off-by: cliu-us <cliu@us.ibm.com>
Signed-off-by: cliu-us <cliu@us.ibm.com>
Signed-off-by: cliu-us <cliu@us.ibm.com>
Signed-off-by: cliu-us <cliu@us.ibm.com>
Signed-off-by: cliu-us <cliu@us.ibm.com>
Signed-off-by: cliu-us <cliu@us.ibm.com>
chichun-charlie-liu
requested review from
BrandonGroth,
andrea-fasoli,
kcirred,
nwang-ibm and
tharapalanivel
as code owners
BrandonGroth
reviewed
Jul 9, 2025
BrandonGroth
reviewed
Jul 9, 2025
BrandonGroth
reviewed
Jul 9, 2025
BrandonGroth
reviewed
Jul 9, 2025
Collaborator
BrandonGroth
left a comment
BrandonGroth
left a comment
There was a problem hiding this comment.
Will review again once set up as a PR
Signed-off-by: cliu-us <cliu@us.ibm.com>
BrandonGroth
approved these changes
Jul 10, 2025
chichun-charlie-liu
merged commit 0e98567
into
foundation-model-stack:main
11 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
in addition to INT8 AIU simulation, now FP8 is added to the triton kernel. AIU FP8 is using "DL8" matmul accumulated in "DL16", slightly different from GPU's FP8 e4m3 accum in FP32 (GPU local accumulator only uses ~22bits mantissa).
Was the PR tested
Checklist for passing CI/CD:
git commit -signoffor equivalenttox -e fixtox -e linttox -e spellchecktox -e unitNote: CI/CD performs unit tests on multiple versions of Python from a fresh install. There may be differences with your local environment and the test environment.