feat: triton matmul kernel adjusted, now is closer to HW behavior#82
Merged
BrandonGroth merged 9 commits intoApr 4, 2025
Merged
Conversation
Signed-off-by: cliu-us <cliu@us.ibm.com>
Signed-off-by: cliu-us <cliu@us.ibm.com>
…descriptions to avoid confusion Signed-off-by: cliu-us <cliu@us.ibm.com>
Signed-off-by: cliu-us <cliu@us.ibm.com>
chichun-charlie-liu
changed the title
Signed-off-by: cliu-us <cliu@us.ibm.com>
Signed-off-by: cliu-us <cliu@us.ibm.com>
chichun-charlie-liu
requested review from
BrandonGroth,
andrea-fasoli,
kcirred,
nwang-ibm and
tharapalanivel
as code owners
BrandonGroth
approved these changes
Apr 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
add a flag
truncate_then_accumulateto allow truncation on partial dot product, i.e. one output from a CUDA instruction, before accumulating into final sum. (Previous behavior is to first accumulate into final sum then truncate.)Related issue number
How to verify the PR
Was the PR tested