chore: increase test coverage in multi-nicd to 60%#314
Merged
minmzzhang merged 1 commit intoAug 4, 2025
Merged
Conversation
sunya-ch
force-pushed
the
upgrade-multi-nicd-ginkgo
branch
from
7bc9182 to
3db5351
Compare
3 tasks
sunya-ch
force-pushed
the
upgrade-multi-nicd-ginkgo
branch
5 times, most recently
from
7b1d8f7 to
d215a81
Compare
sunya-ch
changed the title
minmzzhang
reviewed
Jul 31, 2025
minmzzhang
left a comment
minmzzhang
left a comment
Collaborator
There was a problem hiding this comment.
Hi @sunya-ch , do we want to move to go 1.24.1 as the main go.mod is referencing to?
minmzzhang
approved these changes
Jul 31, 2025
minmzzhang
left a comment
minmzzhang
left a comment
Collaborator
There was a problem hiding this comment.
Other than the go version, LGTM!
sunya-ch
force-pushed
the
upgrade-multi-nicd-ginkgo
branch
from
d215a81 to
c27753b
Compare
Collaborator
Author
|
@minmzzhang I'm not sure whether that will affect the other part for version upgrade. May I have a follow-up PR to upgrade the version instead of this PR? issue to track: |
sunya-ch
added
the
kind/chore
sunya-ch
changed the title
Signed-off-by: Sunyanan Choochotkaew <sunyanan.choochotkaew1@ibm.com>
sunya-ch
force-pushed
the
upgrade-multi-nicd-ginkgo
branch
from
c27753b to
94bf0aa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Increase test coverage in multi-nicd
27.4% --> 52.2% --> 59.8%
Which issue(s) this PR is related to: