docs: add cni-plugins#322
Merged
Merged
Conversation
Signed-off-by: Sunyanan Choochotkaew <sunyanan.choochotkaew1@ibm.com>
Signed-off-by: Sunyanan Choochotkaew <sunyanan.choochotkaew1@ibm.com>
sunya-ch
added
the
kind/chore
…ulti-nicd-ginkgo
Signed-off-by: Sunyanan Choochotkaew <sunyanan.choochotkaew1@ibm.com>
minmzzhang
approved these changes
Aug 7, 2025
minmzzhang
left a comment
minmzzhang
left a comment
Collaborator
There was a problem hiding this comment.
Other than the SR-IOV args, all LGTM!
| | `ipvlan` | `master`, `mode`, `mtu` | | ||
| | `macvlan` | `master`, `mode`, `mtu` | | ||
| | `awsipvlan`| `primaryIP`, `podIP`, `master`, `mode`, `mtu` | | ||
| | `sriov` | `vlan`, `vlanQos`, `spoofchk`, `trust`, `min_tx_rate`, `max_tx_rate` | |
Collaborator
There was a problem hiding this comment.
Do we need to add numVfs, isRdma in to the supported args?
Collaborator
Author
There was a problem hiding this comment.
@minmzzhang You are right. I miss adding the supported args for creating SriovNetworkNodePolicy. Thank you!
Updated as below.
…ulti-nicd-go Upgrade multi nicd go
sunya-ch
force-pushed
the
add-compatible-cni
branch
from
5b19483 to
f0ff2a7
Compare
Signed-off-by: Sunyanan Choochotkaew <sunyanan.choochotkaew1@ibm.com>
sunya-ch
force-pushed
the
add-compatible-cni
branch
from
f0ff2a7 to
16b66a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kind/chore
What this PR does / why we need it:
Explicitly list supported CNIs
Which issue(s) this PR is related to:
Closes #318