Skip to content

Commit b2e6d89

Browse files
Merge pull request #82 from foundersandcoders/refactor/mapping-screens-app-shell
Mapping Screens Get the Framed Terminal Treatment
2 parents d28a969 + dd11c9e commit b2e6d89

9 files changed

Lines changed: 523 additions & 390 deletions

File tree

.claude/CLAUDE.md

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -84,13 +84,6 @@ git push --tags
8484
- **Import style:** `import * as fixtures from '../fixtures/<module>'`
8585
- **Rationale:** Keeps tests focused on assertions, makes test data reusable, and simplifies maintenance
8686

87-
### Code Editing
88-
89-
**IMPORTANT:** Do not edit files directly unless explicitly asked. Instead:
90-
91-
1. Show the proposed code
92-
2. Wait for the user to make the edit themselves
93-
9487
### Database
9588

9689
No database. File-based storage for:

docs/roadmaps/v5a-2606/enhanced.md

Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ because the shell rollout and signature features build on them.
1515
|-------|--------------------------------------------------------------|--------|
1616
| **A** | Foundations (theme, layout primitives, keymap) | Complete |
1717
| **S** | Security & dependency maintenance (Dependabot) | Complete |
18-
| **B** | App-shell rollout across screens | In Progress (B1, B2 done) |
18+
| **B** | App-shell rollout across screens | In Progress (B1-B4 done) |
1919
| **C** | Signature UX features (help, toasts, progress, transitions) | Ready |
2020
| **D** | Polish (palette, command palette, dark mode, schema display) | Blocked (needs B) |
2121
| **E** | Tutorial & demo resources (Charm VHS recordings) | Blocked (needs B/C) |
@@ -214,11 +214,20 @@ registry, and a header breadcrumb.
214214
`bun run test:core` 474/474 unaffected; no new `tsc` diagnostics (the
215215
5 pre-existing `updateSelectOptions` possibly-undefined errors predate
216216
this branch, confirmed via `git stash` comparison).
217-
- [ ] **TR.B3** `refactor/workflow-app-shell` — Processing screen into the frame
218-
(sets up TR.C3). — **depends on TR.S2**
219-
- [ ] **TR.B4** `refactor/results-screens-app-shell` — validation-explorer +
217+
- [x] **TR.B3** `refactor/workflow-app-shell` — Processing screen into the frame
218+
(sets up TR.C3). — **depends on TR.S2**. **Done:** rebuilt the
219+
processing/workflow screen on `appShell()` + `panel()` + `Keymap`,
220+
following the dashboard reference adopter. Merged via PR #78.
221+
- [x] **TR.B4** `refactor/results-screens-app-shell` — validation-explorer +
220222
check-results + success; two-pane framing with a real focused-panel border.
221-
**depends on TR.S2**
223+
**depends on TR.S2**. **Done:** migrated the three results screens
224+
(`validation-explorer`, `check-results`, `success`) onto `appShell()` +
225+
`panel()` + `Keymap`. The two-pane screens get a **real focused-panel
226+
border** via `panel.setFocused()` (accent vs muted), and `togglePanel()`
227+
blurs the leaving pane so border and keyboard focus stay in sync (fix
228+
commit `6ae7750`). Filter-tab selection aligned with the default
229+
`currentFilter` (`377ed0a`). Merged via PRs #79 (success), #80
230+
(check-results), #81 (validation-explorer).
222231
- [ ] **TR.B5** `refactor/mapping-screens-app-shell` — mapping-builder /
223232
-editor / -save; fixes the weak two-panel focus model. — **depends on TR.S2**
224233
- [ ] **TR.B6** `refactor/config-screens-app-shell` — settings + history + about.

0 commit comments

Comments
 (0)