improvement

Author: jaimebarrancos

crates/evm/traces/src/lib.rs

@@ -15,6 +15,7 @@ use foundry_common::{
     contracts::{ContractsByAddress, ContractsByArtifact},
     shell,
 };
+use foundry_config::NamedChain::SuperpositionTestnet;
 use revm::bytecode::opcode::OpCode;
 use revm_inspectors::tracing::{
     OpcodeFilter,
@@ -210,27 +211,34 @@ pub fn render_trace_arena_inner(
     }
 
     // Remove overlapping decoded trace data
-    let mut cloned_arena = arena.clone();
-    for node in cloned_arena.nodes_mut() {
-        for step in &mut node.trace.steps {
-            if step.decoded.is_some() {
-                step.storage_change = None;
+    let mut resolved = arena.resolve_arena();
+
+    let mut tempo_changes = String::new();
+    if with_storage_changes {
+        append_tempo_channel_storage_decodes(&mut tempo_changes, &resolved);
+    }
+
+    let resolved_mut = resolved.to_mut();
+    if with_storage_changes {
+        for node in resolved_mut.nodes_mut() {
+            for step in &mut node.trace.steps {
+                if step.decoded.is_some() {
+                    step.storage_change = None;
+                }
             }
         }
     }
 
-    let resolved = cloned_arena.resolve_arena();
     let mut w = TraceWriter::new(Vec::<u8>::new())
         .color_cheatcodes(true)
         .use_colors(convert_color_choice(shell::color_choice()))
         .write_bytecodes(with_bytecodes)
         .with_storage_changes(with_storage_changes);
-    w.write_arena(&resolved).expect("Failed to write traces");
+    w.write_arena(&resolved_mut).expect("Failed to write traces");
     let mut rendered =
         String::from_utf8(w.into_writer()).expect("trace writer wrote invalid UTF-8");
-    if with_storage_changes {
-        append_tempo_channel_storage_decodes(&mut rendered, &arena.resolve_arena());
-    }
+    rendered.push_str(&tempo_changes);
+
     rendered
 }