fix(evm): align local create2 setup with configured deployer#14016
fix(evm): align local create2 setup with configured deployer#14016ArshLabs wants to merge 4 commits intofoundry-rs:masterfrom
Conversation
|
Hi @ArshLabs, thanks for your fix! This is a sensitive code path so I would like to see additional tests for it for |
Added the requested forge test coverage for custom CREATE2 deployer in both local and forked paths, and pushed the update. Both new tests pass locally. |
…deployer-setup-alignment # Conflicts: # crates/evm/evm/src/executors/mod.rs
|
cc @DaniPopes @mattsse @grandizzy @zerosnacks @onbjerg @0xrusowsky I merged latest master into this branch, resolved the conflict, and pushed the updated commits. I also re-ran the custom CREATE2 deployer coverage: -forge test (local) All of these passed locally. |
Motivation
When
create2_deployeris customized, local setup currently checks or deploys only the default deployer address, while CREATE2 execution uses the inspector-configured address. This can make setup and runtime target different addresses and lead tomissing CREATE2 deployerreverts even though setup already ran.Solution
deploy_create2_deployernow resolves the deployer address from the executor inspector, so setup and runtime CREATE2 execution use the same address.Behavior by case:
A regression test is added for
forge scriptno-endpoint execution with--create2-deployerto verify custom deployer setup aligns with runtime behavior.PR Checklist