fix(anvil): handle BlockTransactions::Uncle without panic#14135
Merged
Conversation
strmfos
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
mattsse,
onbjerg and
zerosnacks
as code owners
zerosnacks
approved these changes
Apr 7, 2026
Member
zerosnacks
left a comment
zerosnacks
left a comment
There was a problem hiding this comment.
Thanks @strmfos! Agreed we should not have a panic here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Panics in RPC server are not acceptable. When
BlockTransactions::Uncleis encountered, returnOk(None)instead of crashing.This variant appears due to alloy deserialization quirk (alloy-rs/alloy#805) and other anvil handlers already handle it gracefully (api.rs returns 0 for tx count).
Introduced in 51632c4 (#13647).
Related: #8822 (similar panic fix in Otterscan).