refactor(cast): fold run_tempo_keychain into run_generic as AccessKey case#14137
Merged
zerosnacks merged 3 commits intoApr 7, 2026
Merged
Conversation
…s-key case Delete the standalone `run_tempo_keychain` method and handle Tempo access key signing as Case 3 inside `run_generic::<TempoNetwork>`. - `run_generic` now accepts `access_key: Option<TempoAccessKeyConfig>` - `run()` routes both keychain and non-keychain Tempo flows through `run_generic::<TempoNetwork>`, eliminating the early dispatch branch - `key_id` is injected into `tx.tempo` before builder construction so gas estimation sees the correct access key address - Keychain signing uses `sign_with_access_key_provisioning`, which encapsulates the provisioning check and `key_authorization` embedding that were previously done manually in `run_tempo_keychain`
mablr
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
mattsse,
onbjerg and
zerosnacks
as code owners
zerosnacks
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Leverage new
FoundryTransactionBuildermethods introduced in #14120 (stacked on top) to remove standalonerun_tempo_keychainmethod and handle Tempo access key signing as Case 3 insiderun_generic::<TempoNetwork>.run_genericnow acceptsaccess_key: Option<TempoAccessKeyConfig>run()routes both keychain and non-keychain Tempo flows throughrun_generic::<TempoNetwork>, eliminating the early dispatch branchkey_idis injected intotx.tempobefore builder construction so gas estimation sees the correct access key addressFoundryTransactionBuilder::sign_with_access_key_provisioning, which encapsulates the provisioning check andkey_authorizationembedding that were previously done manually inrun_tempo_keychain