fix(test): wildcard P256VERIFY gas in osaka snapshot#14287
Merged
Conversation
The P256VERIFY precompile gas cost was reduced from 6900 to 3450, but the flaky_osaka_can_run_p256_precompile snapshot still had the old value hardcoded. Replace with [..] for consistency with the rest of the snapshot. Closes #14282 Closes #14283 Co-Authored-By: zerosnacks <95942363+zerosnacks@users.noreply.github.com> Amp-Thread-ID: https://ampcode.com/threads/T-019d8681-ae7d-712f-b4e7-eb6f595f82e3
decofe
requested review from
0xrusowsky,
DaniPopes,
figtracer,
grandizzy,
mablr,
mattsse,
onbjerg,
stevencartavia and
zerosnacks
as code owners
DaniPopes
approved these changes
Apr 13, 2026
zerosnacks
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The P256VERIFY precompile gas cost was reduced from 6900 to 3450, but the
flaky_osaka_can_run_p256_precompilesnapshot still had the old value hardcoded. This was missed in #14278 which already wildcarded most other gas values in this snapshot.Replace
[6900]with[..]for consistency.Analysis of #14282 and #14283:
flaky_osaka_can_run_p256_precompilefailed deterministically on all 6 retries in both isolate and non-isolate runs — fixed by this PRflaky_decode_external_libraries_with_cached_selectorsonly failed on TRY 1 in isolate mode and succeeded on retry — genuine flaky behavior, no code fix neededflaky_expect_emit_tests_should_failonly failed on TRY 1 in isolate mode and succeeded on retry — genuine flaky behavior, no code fix neededCloses #14282
Closes #14283
Prompted by: zerosnacks